Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't change a relative month filter's values when using the "starting from" feature #22227

Closed
mazameli opened this issue Apr 28, 2022 · 0 comments · Fixed by #22321
Closed

Can't change a relative month filter's values when using the "starting from" feature #22227

mazameli opened this issue Apr 28, 2022 · 0 comments · Fixed by #22321
Assignees
@akiselev
Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Milestone
0.43

Comments

@mazameli
Copy link
Contributor

mazameli commented Apr 28, 2022 •
edited by flamber

To repro:

  • Open up the Orders table
  • Click on the Created At column and click the "filter on this column action," then select relative dates
  • Set the filter to previous 1 month, starting from 3 months ago, and add the filter
  • Click on the filter token in the top-left to reopen the filter
  • Try changing the 1 month to any other quantity, like 3 months, then try to update the filter
  • The changes are not applied, and when you reopen the filter again it has reverted to the previous value
Can.t.change.the.month.filter.mp4

https://www.loom.com/share/f43cf9608f3a47af91daa9b8fcb8b14a
@mazameli mazameli added Type:Bug Product defects Querying/GUI Query builder catch-all, including simple mode .Needs Triage .bugbash labels Apr 28, 2022
@flamber flamber added Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend and removed .Needs Triage labels May 1, 2022
@flamber flamber added this to the 0.43 milestone May 1, 2022
@akiselev akiselev mentioned this issue May 2, 2022
Merged
akiselev pushed a commit that referenced this issue May 2, 2022
Fix several bugs in relative datetime filters (#22321)
76b1734 
**Changing the granularity of the `Past`/`Next` range picker now changes the granularity of the `Starting from` option**
  - Fixes #22222
  - Reproduces #22222 

---

**`Include this quarter` now displays correctly**
  - Fixes #22224 

---

**Now shows the correct date preview in `Past`/`Next` range picker**
  - Fixes #22225 
  - Reproduces #22225 

---

**Can now change `Past`/`Next` granularity when the value is set to `1`**
  - Fixes #22227
  - Reproduces #22227

---

**`Next` relative filter pill text now reads `from now` instead of `ago`**
  - Fixes #22228
  - Reproduces #22228
github-actions bot pushed a commit that referenced this issue May 2, 2022
Fix several bugs in relative datetime filters (#22321)
8244c75 
**Changing the granularity of the `Past`/`Next` range picker now changes the granularity of the `Starting from` option**
  - Fixes #22222
  - Reproduces #22222 

---

**`Include this quarter` now displays correctly**
  - Fixes #22224 

---

**Now shows the correct date preview in `Past`/`Next` range picker**
  - Fixes #22225 
  - Reproduces #22225 

---

**Can now change `Past`/`Next` granularity when the value is set to `1`**
  - Fixes #22227
  - Reproduces #22227

---

**`Next` relative filter pill text now reads `from now` instead of `ago`**
  - Fixes #22228
  - Reproduces #22228
akiselev pushed a commit that referenced this issue May 2, 2022
@github-actions
Fix several bugs in relative datetime filters (#22321) (#22336)
3aa65a0 
**Changing the granularity of the `Past`/`Next` range picker now changes the granularity of the `Starting from` option**
  - Fixes #22222
  - Reproduces #22222 

---

**`Include this quarter` now displays correctly**
  - Fixes #22224 

---

**Now shows the correct date preview in `Past`/`Next` range picker**
  - Fixes #22225 
  - Reproduces #22225 

---

**Can now change `Past`/`Next` granularity when the value is set to `1`**
  - Fixes #22227
  - Reproduces #22227

---

**`Next` relative filter pill text now reads `from now` instead of `ago`**
  - Fixes #22228
  - Reproduces #22228

Co-authored-by: Alexander Kiselev <alexander.kiselev@metabase.com>
This was referenced Nov 21, 2022
Merged
Merged
Merged
This was referenced Nov 29, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 7, 2022
Merged
Merged
Merged
Merged
This was referenced Oct 19, 2023
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akiselev akiselev

Labels
.Frontend Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

Fix several bugs in relative datetime filters metabase/metabase
3 participants
@akiselev @flamber @mazameli