Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to properly filter on an aggregation #22230

Closed
ariya opened this issue Apr 28, 2022 · 3 comments · Fixed by #29539
Closed

Unable to properly filter on an aggregation #22230

ariya opened this issue Apr 28, 2022 · 3 comments · Fixed by #29539
Assignees
@WiNloSt
Labels
Difficulty:Medium .Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone
0.46.1

Comments

@ariya
Copy link
Contributor

ariya commented Apr 28, 2022 •
edited

In the notebook, when filtering an aggregation (e.g. Max of something) that is not a number, the widget is useless.

To Reproduce

  1. New, Question, Sample Database, People
  2. Summarize, Maximum of Name, group by Source
  3. Filter, Max of Name

Regardless what is being typed in the text box, the Add filter button remains disabled.

image

Also, looking at the network, there are 404 calls to http://localhost:3000/api/field//values (clearly, the field is is missing).

Workaround

Create a custom column, trim([Max of Name]), name it as e.g. MaxName, and filter on that instead.

image

Expected behavior

Filtering some aggregation like Max of Name above should be easy and pleasant.
@ariya ariya added Type:Bug Product defects .Needs Triage labels Apr 28, 2022
@ariya
Copy link
Contributor Author

ariya commented Apr 28, 2022

Previously: #21973.

@ariya ariya added Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Frontend Querying/GUI Query builder catch-all, including simple mode and removed .Needs Triage labels Apr 28, 2022
@ariya ariya mentioned this issue Apr 29, 2022
Merged
@ariya ariya linked a pull request Apr 30, 2022 that will close this issue
Treat type/Category as STRING for the purpose of filtering #22231
Merged
@ariya ariya removed a link to a pull request Apr 30, 2022
Treat type/Category as STRING for the purpose of filtering #22231
Merged
@flamber flamber added the Priority:P2 Average run of the mill bug label May 2, 2022
@flamber
Copy link
Contributor

flamber commented May 2, 2022

Seems very similar to #19013

@nemanjaglumac
Copy link
Member

If you choose "Not empty", then "Add filter" becomes enabled but the query fails with the non-existing endpoint.

GET /api/field//values (notice two //)

nemanjaglumac added a commit that referenced this issue Jul 12, 2022
@nemanjaglumac
Add repro for #22230
4ae9fea
@nemanjaglumac nemanjaglumac mentioned this issue Jul 12, 2022
Merged
nemanjaglumac added a commit that referenced this issue Jul 13, 2022
@nemanjaglumac
Repro #22230: Unable to properly filter on an aggregation (max of) (#…
9a68cfc 
…23869)
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label Jul 13, 2022
github-actions bot pushed a commit that referenced this issue Jul 13, 2022
@nemanjaglumac
Repro #22230: Unable to properly filter on an aggregation (max of) (#…
e3c43fd 
…23869)
nemanjaglumac added a commit that referenced this issue Jul 13, 2022
@github-actions @nemanjaglumac
Repro #22230: Unable to properly filter on an aggregation (max of) (#…
c1dc291 
…23869) (#23886)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
WiNloSt added a commit that referenced this issue Mar 24, 2023
@WiNloSt
Add a reproduction for #22230
30fef3d
@WiNloSt WiNloSt mentioned this issue Mar 24, 2023
Merged
WiNloSt added a commit that referenced this issue Mar 28, 2023
@WiNloSt
Add a reproduction for unable to properly filter on an aggregation (#…
0387f11 
…29539)

* Add a reproduction for #22230

* Clean up comments
github-actions bot pushed a commit that referenced this issue Mar 28, 2023
@WiNloSt
Add a reproduction for unable to properly filter on an aggregation (#…
0d7567e 
…29539)

* Add a reproduction for #22230

* Clean up comments
WiNloSt added a commit that referenced this issue Mar 28, 2023
@WiNloSt
Remove duplicate reproductions for #22230
57e8356
@WiNloSt WiNloSt mentioned this issue Mar 28, 2023
Merged
1 task
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WiNloSt WiNloSt

Labels
Difficulty:Medium .Frontend Priority:P2 Average run of the mill bug Querying/GUI Query builder catch-all, including simple mode Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
0.46.1
Development

Successfully merging a pull request may close this issue.

Add a reproduction for unable to properly filter on an aggregation metabase/metabase
6 participants
@ariya @flamber @WiNloSt @alxnddr @nemanjaglumac @darksciencebase