Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the last column in a table visualization resets all columns #29140

Closed
Tracked by #31321
EmmadUsmani opened this issue Mar 10, 2023 · 2 comments · Fixed by #31856
Closed
Tracked by #31321

removing the last column in a table visualization resets all columns #29140

EmmadUsmani opened this issue Mar 10, 2023 · 2 comments · Fixed by #31856
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Milestone

Comments

@EmmadUsmani
Copy link
Contributor

Describe the bug
When removing the last column from a table visualization, if the column is a joined column, then after removing it all columns will reappear.

Logs

[backend] 2023-03-10 12:13:56,016 WARN api.common :: Unexpected parameters at [:post "/"]: [:type :database :query :parameters]
[backend] Please add them to the schema or remove them from the API client
[backend] 2023-03-10 12:13:56,100 DEBUG middleware.log :: POST /api/dataset 202 [ASYNC: completed] 84.1 ms (25 DB calls) App DB connections: 1/4 Jetty threads: 4/50 (1 idle, 0 queued) (86 total active threads) Queries in flight: 0 (0 queued); h2 DB 1 connections: 0/2 (0 threads blocked)

To Reproduce

  1. Open a table visualization (from model, table, or question).
  2. Add a joined column (can do this from visualization settings sidebar).
  3. Remove all other columns (click eye icon in sidebar), then remove the joined column.
  4. All original columns from the table will reappear in the visualization.

Expected behavior
Columns should not reappear, table should be empty.

Screenshots/videos

Screen.Recording.2023-03-10.at.12.04.34.PM.mov

Information about your Metabase Installation:
master branch commit b2a822cb2b

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/111.0",
    "vendor": ""
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "17.0.6+10",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "17.0.6",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "17.0.6+10",
    "os.name": "Mac OS X",
    "os.version": "13.0",
    "user.language": "en",
    "user.timezone": "America/Los_Angeles"
  },
  "metabase-info": {
    "databases": [
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2023-03-08",
      "src_hash": "5b2936dc350df411dc567059489c9ff8ef59f0f3",
      "tag": "v0.46.0-SNAPSHOT",
      "branch": "master",
      "hash": "4e30153"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity
Minor annoyance, not very severe.

@EmmadUsmani EmmadUsmani added Type:Bug Product defects .Needs Triage Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed Type:Bug Product defects .Needs Triage labels Mar 10, 2023
@qnkhuat
Copy link
Contributor

qnkhuat commented Mar 13, 2023

@EmmadUsmani what's your assessment on this issue, is this FE or BE?

@EmmadUsmani
Copy link
Contributor Author

@qnkhuat I believe FE, as there's nothing in the backend response that has to do with the visualization settings on the columns.

@npfitz npfitz self-assigned this Jun 26, 2023
@npfitz npfitz linked a pull request Jun 26, 2023 that will close this issue
1 task
@npfitz npfitz added this to the 0.47 milestone Jul 10, 2023
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants