Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate docs version list update in release process #37613

Closed
wants to merge 1 commit into from

Conversation

iethree
Copy link
Contributor

@iethree iethree commented Jan 11, 2024

Closes https://github.com/metabase/metabase-private/issues/170

Description

This is long overdue. Invokes @jeff-bruemmer's version list updating script in ci. This new release step will open a PR and mark the

Testing

  • need to test in my fork

@iethree iethree requested review from jeff-bruemmer and a team January 11, 2024 21:52
@iethree iethree self-assigned this Jan 11, 2024
@iethree iethree changed the title Automate docs update in release process Automate docs version list update in release process Jan 11, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Jan 11, 2024
"gh release list --repo metabase/metabase --limit 10000 --exclude-pre-releases --exclude-drafts")
"gh release list --repo metabase/metabase --limit 10000 --exclude-pre-releases")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we're running this right after the draft notes are generated, we need to include drafts, right?

@iethree iethree added the no-backport Do not backport this PR to any branch label Jan 11, 2024
Copy link

replay-io bot commented Jan 11, 2024

StatusComplete ↗︎
Commitbc799d0
Results
⚠️ 2 Flaky
  • should work for longitude
      Timed out retrying after 4000ms: Unable to find an element with the text: Saved Questions. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.
      Ignored nodes: comments, <script />, <style />
      <html
        lang="en"
        translate="no"
      >
        <head>
          <meta
            charset="utf-8"
          />
          <meta
            content="IE=edge"
            http-equiv="X-UA-Compatible"
          />
          <meta
            content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no"
            name="viewport"
          />
          <meta
            content="noindex"
            name="robots"
          />
          <meta
            content="yes"
            name="apple-mobile-web-app-capable"
          />
          <meta
            content="black-translucent"
            name="apple-mobile-web-app-status-bar-style"
          />
          <link
            href="app/assets/img/apple-touch-icon.png"
            rel="apple-touch-icon"
            sizes="180x180"
          />
          <link
            href="app/assets/img/favicon.ico"
            rel="icon"
          />
          <link
            crossorigin="use-credentials"
            href="app/assets/img/site.webmanifest"
            rel="manifest"
          />
          <meta
            content="#2d89ef"
            name="msapplication-TileColor"
          />
          <meta
            content="app/assets/img/browserconfig.xml"
            name="msapplication-config"
          />
          <meta
            content="#ffffff"
            name="theme-color"
          />
          <meta
            content="default"
            name="apple-mobile-web-app-status-bar-style"
          />
          <meta
            content="/"
            name="base-href"
          />
          <meta
            content="/question/notebook"
            name="uri"
          />
          <title>
            Question · Metabase
          </title>
          <base
            href="/"
          />
          <link
            href="app/dist/styles.3ddf973fc967572ec34c.css"
            rel="stylesheet"
          />
          <link
            href="app/dist/app-main.8c3db53cb80ee9443da7.css"
            rel="stylesheet"
          />
        </head>
        <body>
          <div
            id="root"
          >
            <div
              class="spread emotion-1fttcpj enx0u2k2"
            >
              <header
                aria-label="Navigation bar"
                class="emotion-15xkiw5 es0756t0"
                data-testid="app-bar"
              >
                <div
                  class="emotion-1pt930v e4w71dr4"
                >
                  <div
                    class="emotion-cxb03 e4w71dr3"
                  >
                    <div
                      class="emotion-bjn8wh ehgm33i2"
                    >
                      <a
                        class="ehgm33i1 emotion-m53806 emeibx70"
                        data-metabase-event="Navbar;Logo"
                        href="/"
                      >
                        <svg
                          class="Icon text-brand"
                          data-testid="main-logo"
                          fill="currentcolor"
                          height="32"
                          viewBox="0 0 66 85"
                        >
                          <path
                            d="M46.8253288,70.4935014 C49.5764899,70.4935014 51.8067467,68.1774705 51.8067467,65.3205017 C51.8067467,62.4635329 49.5764899,60.147502 46.8253288,60.147502 C44.0741676,60.147502 41.8439108,62.4635329 41.8439108,65.3205017 C41.8439108,68.1774705 44.0741676,70.4935014 46.8253288,70.4935014 Z M32.8773585,84.9779005 C35.6285197,84.9779005 37.8587764,82.6618697 37.8587764,79.8049008 C37.8587764,76.947932 35.6285197,74.6319011 32.8773585,74.6319011 C30.1261973,74.6319011 27.8959405,76.947932 27.8959405,79.8049008 C27.8959405,82.6618697 30.1261973,84.9779005 32.8773585,84.9779005 Z M32.8773585,70.4935014 C35.6285197,70.4935014 37.8587764,68.1774705 37.8587764,65.3205017 C37.8587764,62.4635329 35.6285197,60.147502 32.8773585,60.147502 C30.1261973,60.147502 27.8959405,62.4635329 27.8959405,65.3205017 C27.8959405,68.1774705 30.1261973,70.4935014 32.8773585,70.4935014 Z M18.9293882,70.4935014 C21.6805494,70.4935014 23.9108062,68.1774705 23.9108062,65.3205017 C23.9108062,62.4635329 21.6805494,60.147502 18.9293882,60.147502 C16.1782271,60.147502 13.9479703,62.4635329 13.9479703,65.3205017 C13.9479703,68.1774705 16.1782271,70.4935014 18.9293882,70.4935014 Z M46.8253288,56.0091023 C49.5764899,56.0091023 51.8067467,53.6930714 51.8067467,50.8361026 C51.8067467,47.9791337 49.5764899,45.6631029 46.8253288,45.6631029 C44.0741676,45.6631029 41.8439108,47.9791337 41.8439108,50.8361026 C41.8439108,53.6930714 44.0741676,56.0091023 46.8253288,56.0091023 Z M18.9293882,56.0091023 C21.6805494,56.0091023 23.9108062,53.6930714 23.9108062,50.8361026 C23.9108062,47.9791337 21.6805494,45.6631029 18.9293882,45.6631029 C16.1782271,45.6631029 13.9479703,47.9791337 13.9479703,50.8361026 C13.9479703,53.6930714 16.1782271,56.0091023 18.9293882,56.0091023 Z M46.8253288,26.8995984 C49.5764899,26.8995984 51.8067467,24.5835675 51.8067467,21.7265987 C51.8067467,18.8696299 49.5764899,16.553599 46.8253288,16.553599 C44.0741676,16.553599 41.8439108,18.8696299 41.8439108,21.7265987 C41.8439108,24.5835675 44.0741676,26.8995984 46.8253288,26.8995984 Z M32.8773585,41.5247031 C35.6285197,41.5247031 37.8587764,39.2086723 37.8587764,36.3517034 C37.8587764,33.4947346 35.6285197,31.1787037 32.8773585,31.1787037 C30.1261973,31.1787037 27.8959405,33.4947346 27.8959405,36.3517034 C27.8959405,39.2086723 30.1261973,41.5247031 32.8773585,41.5247031 Z M32.8773585,10.3459994 C35.6285197,10.3459994 37.8587764,8.02996853 37.8587764,5.17299969 C37.8587764,2.31603085 35.6285197,0 32.8773585,0 C30.1261973,0 27.8959405,2.31603085 27.8959405,5.17299969 C27.8959405,8.02996853 30.1261973,10.3459994 32.8773585,10.3459994 Z M32.8773585,26.8995984 C35.6285197,26.8995984 37.8587764,24.5835675 37.8587764,21.7265987 C37.8587764,18.8696299 35.6285197,16.553599 32.8773585,16.553599 C30.1261973,16.553599 27.8959405,18.8696299 27.8959405,21.7265987 C27.8959405,24.5835675 30.1261973,26.8995984 32.8773585,26.8995984 Z M18.9293882,26.8995984 C21.6805494,26.8995984 23.9108062,24.5835675 23.9108062,21.7265987 C23.9108062,18.8696299 21.6805494,16.553599 18.9293882,16.553599 C16.1782271,16.553599 13.9479703,18.8696299 13.9479703,21.7265987 C13.9479703,24.5835675 16.1782271,26.8995984 18.9293882,26.8995984 Z"
                            opacity="0.2"
                          />
                          <path
                            d="M60.773299,70.4935014 C63.5244602,70.4935014 65.754717,68.1774705 65.754717,65.3205017 C65.754717,62.4635329 63.5244602,60.147502 60.773299,60.147502 C58.0221379,60.147502 55.7918811,62.4635329 55.7918811,65.3205017 C55.7918811,68.1774705 58.0221379,70.4935014 60.773299,70.4935014 Z M4.98141795,70.3527958 C7.73257912,70.3527958 9.96283591,68.0367649 9.96283591,65.1797961 C9.96283591,62.3228273 7.73257912,60.0067964 4.98141795,60.0067964 C2.23025679,60.0067964 0,62.3228273 0,65.1797961 C0,68.0367649 2.23025679,70.3527958 4.98141795,70.3527958 Z M60.773299,56.0091023 C63.5244602,56.0091023 65.754717,53.6930714 65.754717,50.8361026 C65.754717,47.9791337 63.5244602,45.6631029 60.773299,45.6631029 C58.0221379,45.6631029 55.7918811,47.9791337 55.7918811,50.8361026 C55.7918811,53.6930714 58.0221379,56.0091023 60.773299,56.0091023 Z M32.8773585,56.0091023 C35.6285197,56.0091023 37.8587764,53.6930714 37.8587764,50.8361026 C37.8587764,47.9791337 35.6285197,45.6631029 32.8773585,45.6631029 C30.1261973,45.6631029 27.8959405,47.9791337 27.8959405,50.8361026 C27.8959405,53.6930714 30.1261973,56.0091023 32.8773585,56.0091023 Z M4.98141795,55.8683967 C7.73257912,55.8683967 9.9...
  • with CountIf
2213 Passed

--title "Update docs version list for ${{ inputs.version }}" \
--body "Update version list for ${{ inputs.version }}" \
--reviewer "${GITHUB_ACTOR}" \
--base master \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--base master is a default behavior, but we can keep this line with no harm

@iethree iethree marked this pull request as draft January 16, 2024 16:48
@iethree
Copy link
Contributor Author

iethree commented Jun 3, 2024

closing for now. we'll probably take a slightly different approach and just insert the currently releasing version to avoid the timing issue in reading already-released version from the API

@iethree iethree closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Building & Releasing no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants