-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate docs version list update in release process #37613
Conversation
"gh release list --repo metabase/metabase --limit 10000 --exclude-pre-releases --exclude-drafts") | ||
"gh release list --repo metabase/metabase --limit 10000 --exclude-pre-releases") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since we're running this right after the draft notes are generated, we need to include drafts, right?
|
--title "Update docs version list for ${{ inputs.version }}" \ | ||
--body "Update version list for ${{ inputs.version }}" \ | ||
--reviewer "${GITHUB_ACTOR}" \ | ||
--base master \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--base master
is a default behavior, but we can keep this line with no harm
closing for now. we'll probably take a slightly different approach and just insert the currently releasing version to avoid the timing issue in reading already-released version from the API |
Closes https://github.com/metabase/metabase-private/issues/170
Description
This is long overdue. Invokes @jeff-bruemmer's version list updating script in ci. This new release step will open a PR and mark the
Testing