If you bring the sample dataset back then go to 'Browse Data' it does not appear unless you refresh the page #29496
Assignees
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
camsaul
added
Type:Bug
kamilmielnik
added a commit
that referenced
this issue
May 19, 2023
chalenge
added a commit
to faros-ai/metabase
that referenced
this issue
May 31, 2023
* docs - update notification permissions (metabase#29845) (metabase#29865) Co-authored-by: Natalie <nat@metabase.com> * Backport 9b8ac70 (metabase#29860) * Fix can't join a table with another native question based on the same table (metabase#29879) (metabase#29880) * Convert timezone used to works for redshift, not sure why it's suddenly (metabase#29883) (metabase#29899) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * Fixes convert-timezone tests for redshift (metabase#29923) (metabase#29933) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * [E2E] Add back `Vertica` assertion (metabase#29972) (metabase#29980) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Fix typo in managing-people-groups doc (metabase#29878) (metabase#29992) f -> of Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * update help text for serialization commands (metabase#29993) * [Docs] Fix "Asking questions" introduction (metabase#30032) (metabase#30033) * Update the position description of "clear all filters" * Add missing links to `models` page Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * note on mongo scans (metabase#30017) (metabase#30038) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - note on invitations (metabase#30049) (metabase#30079) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - update saml (metabase#29846) (metabase#30088) Co-authored-by: Natalie <nat@metabase.com> * docs - update full-app embedding (metabase#30085) (metabase#30092) Co-authored-by: Natalie <nat@metabase.com> * Fix not being able to use field filters in databases without schema (metabase#30029) (metabase#30070) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * Cherry-pick c7eb725 (metabase#30118) * [DOCS] Update editing user account instructions (metabase#30135) (metabase#30148) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * docs - break out charts into individual pages (metabase#30129) (metabase#30154) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Removes action_id from v1 dump. Resolves metabase#29528 (metabase#29541) (metabase#30158) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Fix serdes v2 entity id backfill (metabase#29808) (metabase#30159) * Fixes backfill-ids/has-entity-id? * Adds hydration for Action :model * Adds test for Action :model hydration Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * docs - update session expiration, google sign-in, and env vars (metabase#30188) (metabase#30198) Co-authored-by: Natalie <nat@metabase.com> * Include checklist task to migrate off h2 (metabase#30126) (metabase#30210) * Include checklist task to migrate off h2 New checklist item is shown when not hosted and app-db is h2. A divergence from others, this checklist is not shown if it is not triggered. In other words, we don't want to show this task as completed in the UI if they are hosted or using pg, we just want to omit the task completely. This is because we do not know if they upgraded or just started with pg/mysql or started in the cloud. Did lots of cleanup to make this easier to grok and easier to test. Ultimately we don't have to redef a bunch of stuff to test the scenarios. * Fix setup links for external urls * Re-export * Add api types * Add tests * Improve tests * Improve tests * Improve tests * Improve tests * Improve tests * Simplify if * Show checklist as completed when on pg/mysql and not hosted was filtering this out as we can't (easily?) tell if an instance was migrated from h2 -> postgres. So wasn't clear if showing a checked-off task list item made sense. But it does. So we'll show it. We just wont' show it in cloud (hosted) --------- Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * 🍒 Backport Percy fixes and changes (metabase#30192) * [TEMP] Disable the failing Percy spec (metabase#30175) * Increase the request timeout for Percy model editor spec (metabase#30176) * Increase the request timeout for Percy model editor spec * Update e2e/test/visual/models/editor.cy.spec.js Co-authored-by: Tim Macdonald <tim@metabase.com> --------- Co-authored-by: Tim Macdonald <tim@metabase.com> * [CI] Remove matrix strategy from the `percy` job (metabase#30153) * Upgrade Percy CLI to `v1.23.0` (metabase#30179) --------- Co-authored-by: Tim Macdonald <tim@metabase.com> * [DOCS] Fix typo in premium features overview (metabase#30225) (metabase#30228) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Release automation: publish Elastic Beanstalk artifacts (metabase#28516) (metabase#30233) The core logic is still from the release script in bin/release. The change here mostly wiring it up to GitHub Action so that it can be trigged upon a new git tag (during the release process). Co-authored-by: Ariya Hidayat <ariya@metabase.com> * docs - update filters troubleshooting guide (metabase#30203) (metabase#30238) Co-authored-by: Natalie <nat@metabase.com> * docs - update "can't see tables" troubleshooting guide (metabase#30215) (metabase#30239) Co-authored-by: Natalie <nat@metabase.com> * docs - update official collection info (metabase#30231) (metabase#30240) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * update note on plans (metabase#30258) (metabase#30263) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix metric tool-tip description overflow (metabase#30271) (metabase#30279) Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> * fix anchor link (metabase#30276) (metabase#30286) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix inlined number params in native queries (metabase#30265) (metabase#30287) * Fixes inlining of numeric params in native queries * Updates namespaces to use sql.qp/with-driver-honey-sql-version Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Hide multiple values option when connect dashboard filter with question with template tags (metabase#30270) (metabase#30288) * fix typo * driveby type improvement * Fix not showing single or multiple values options When a parameter is connected to a question with template tags * Review: unit tests instead Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * docs - update link and image (metabase#30296) (metabase#30297) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - updates docs home image (metabase#30298) (metabase#30304) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Wait for db delete request to resolve before closing modal (metabase#30194) (metabase#30320) * wait for db delete request to resolve before closing modal * more async shenanigans # Conflicts: # frontend/src/metabase/admin/databases/database.js * [E2E] Fix question moderation flake (metabase#30252) (metabase#30272) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Generate unique aliases for operations in aggregations (metabase#30302) (metabase#30328) Fixes metabase#30262. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * docs - update env vars (metabase#30341) (metabase#30342) Co-authored-by: Natalie <nat@metabase.com> * Manual backport Do not record revision if the object is not changed. (metabase#30285) (metabase#30346) * Do not record revision if the object is not changed. (metabase#30285) * add week (metabase#30358) (metabase#30362) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * add athena example policy (metabase#30359) (metabase#30363) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * bump snowflake to 3.13.30 (metabase#30336) (metabase#30339) Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> * docs - add db privileges, update db connection troubleshooting (metabase#30205) (metabase#30369) Co-authored-by: Natalie <nat@metabase.com> * Fix typo in password reset email template (metabase#30348) (metabase#30388) * Fix typo in password_reset.mustache * Rename "becase" to "because" [ci skip] Co-authored-by: Kartikeya <42073497+fathomer@users.noreply.github.com> * docs - note on column visibility (metabase#30405) (metabase#30414) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix values source modal not handling not having access to the root collection (metabase#30384) (metabase#30393) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * Solve flakiness on FormCreator unit test (metabase#29474) (metabase#29870) Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * docs - fix links (metabase#30432) (metabase#30436) * update link * link Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - script and docs for list of releases (metabase#30403) (metabase#30442) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Update filters.md (metabase#30443) (metabase#30447) Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> * fix link (metabase#30449) (metabase#30450) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix metabase#28973: Disable drag for single fields (metabase#30408) (metabase#30448) * disable drag for single fields * refactor isDragDisabled expression * prevent sub-dimension draggability for sub-dimensions with only 1 item * refactor drag and drop conditionals Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> * remove file (metabase#30451) (metabase#30452) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * fix database info banner link (metabase#30330) (metabase#30428) Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> * Fix metabase#25637: SmartScalars should compactify like Scalars (metabase#30337) (metabase#30427) * copy compact logic from scalar * re-organize compactify logic * move duplicated logic into utils file * move scalarUtils * convert scalar_utils to typescript * add smartscalar unit tests for compactify * add unit tests for compactifyValue * refactor optional parameter * default to compact = false for fullScalarValue * refactor scalar_utils unit tests * 20911 include subcollections permissions (metabase#30426) (metabase#30495) Fix metabase#20911: include subcollections doesn't work Co-authored-by: Roman Abdulmanov <roman@metabase.com> * Manual backport: Fix v1 dump command error when logging entities (metabase#30463) (metabase#30498) Updates v1 dump name-for-logging function to handle Toucan 2 records * Remove CircleCi integration (metabase#30493) (metabase#30526) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Fix metabase#30494: fix subcollection apply logic (metabase#30531) (metabase#30544) Co-authored-by: Roman Abdulmanov <roman@metabase.com> * Escape schema and table names in Snowflake JDBC metadata calls (metabase#30537) (metabase#30548) Fixes metabase#26054. The Snowflake JDBC driver is buggy: schema and table name are interpreted as patterns in DatabaseMetaData.getPrimaryKeys and DatabaseMetaData.getImportedKeys calls. This PR replaces the default JDBC functions with ones that escape the names. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Specify baseUrl for e2e tests (metabase#30520) * docs - slack channel renaming note (metabase#30582) (metabase#30589) * slack channel renaming note * note on alerts Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - update postgres (metabase#30592) (metabase#30607) Co-authored-by: Natalie <nat@metabase.com> * docs - update sso (metabase#30608) * Repro metabase#30535: User session affects embedded question (metabase#30591) (metabase#30595) [ci skip] * don't allow pinned collection card overflow (metabase#30612) (metabase#30618) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * Fixes IP geocoding test (metabase#30605) (metabase#30623) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Ignore Twitter links in markdown link checker (metabase#30621) (metabase#30626) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * docs - update alert docs (metabase#30625) (metabase#30627) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Expand `EntityMenuItem` component test coverage (metabase#30615) (metabase#30636) * Do not render menu item that has both `action` and `link` props * Add unit tests * Address PR comment and refactor tests Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Don't lint non-SSL links either (metabase#30633) (metabase#30641) Co-authored-by: Tim Macdonald <tim@metabase.com> * Don't sandbox embedded queries (metabase#30628) (metabase#30652) * initial fix * unskip repro * use as-admin in more places * macro tweak and unit tests * tweak macro again and add a sandboxing test * fix test * docs - rewrite data sandboxes (metabase#30445) (metabase#30682) Co-authored-by: Natalie <nat@metabase.com> * fix links (metabase#30702) (metabase#30704) Co-authored-by: Natalie <nat@metabase.com> * 🤖 backported "Ignore provided metadata on new cards" (metabase#30649) * Ignore provided metadata on new cards (metabase#30640) * Ignore provided metadata on new cards Fixes metabase#30610 Removed an optimization that was put in place for copying cards that trusted the front end to pass in the correct result_metadata. Now, on new cards we ignore the passed in metadata and recalculate fresh. On models, however, we recalculate fresh metadata and combine it with the provided metadata. * Update test based on PR feedback * Fix backported toucan v toucan2 model ref --------- Co-authored-by: Case Nelson <case@metabase.com> * docs - update data sandbox examples (metabase#30733) (metabase#30736) Co-authored-by: Natalie <nat@metabase.com> * docs - update sandboxes some more (metabase#30738) (metabase#30740) Co-authored-by: Natalie <nat@metabase.com> * [CI] Fix syntax error in slack notifications script (metabase#30660) (metabase#30734) # Conflicts: # .github/workflows/rerun-workflows.yml * docs - pro links (metabase#30742) (metabase#30744) * add links to paid features section * add readme link * update links Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Alternative GEOJSON.io fix (metabase#30675) (metabase#30696) * Alternative GEOJSON.io fix (metabase#30675) * Alternative GEOJSON.io fix rather than not testing, just accept that we might get an expected location back or we might get nil. This actually represents how the application will behave and will seamlessly work as the service improves or continues throwing errors: ```shell ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23" <html> <head><title>500 Internal Server Error</title></head> <body> <center><h1>500 Internal Server Error</h1></center> <hr><center>openresty</center> </body> </html> ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73" [{"area_code":"0","organization_name":"GOOGLE","country_code":"US", "country_code3":"USA","continent_code":"NA","ip":"8.8.8.8", "region":"California","latitude":"34.0544","longitude":"-118.2441", "accuracy":5,"timezone":"America\/Los_Angeles","city":"Los Angeles", "organization":"AS15169 GOOGLE","asn":15169,"country":"United States"}, {"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US", "country_code3":"USA","continent_code":"NA","ip":"136.49.173.73", "region":"Texas","latitude":"30.2423","longitude":"-97.7672", "accuracy":5,"timezone":"America\/Chicago","city":"Austin", "organization":"AS16591 GOOGLE-FIBER","asn":16591,"country":"United States"}] ``` Changes are basically ```clojure (schema= (s/conditional some? <original-expectation-schema> nil? (s/eq nil) response-from-geojson) ``` * Filter to login error messages ```clojure (into [] (map (fn [[log-level error message]] [log-level (type error) message])) error-messages-captured-in-test) [[:error clojure.lang.ExceptionInfo "Error geocoding IP addresses {:url https://get.geojs.io/v1/ip/geo.json?ip=127.0.0.1}"] [:error clojure.lang.ExceptionInfo "Authentication endpoint error"]] ``` * check timestamps with regex seems like they fixed the service ```shell curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23" [{"country":"United States","latitude":"34.0544","longitude":"-118.2441","accuracy":5,"timezone":"America\/Los_Angeles","ip":"8.8.8.8","organization":"AS15169 GOOGLE","country_code3":"USA","asn":15169,"area_code":"0","organization_name":"GOOGLE","country_code":"US","city":"Los Angeles","continent_code":"NA","region":"California"},{"country":"United States","latitude":"30.2423","longitude":"-97.7672","accuracy":5,"timezone":"America\/Chicago","ip":"136.49.173.73","organization":"AS16591 GOOGLE-FIBER","country_code3":"USA","asn":16591,"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US","city":"Austin","continent_code":"NA","region":"Texas"},{"country":"France","latitude":"48.8582","longitude":"2.3387","accuracy":500,"timezone":"Europe\/Paris","ip":"185.233.100.23","organization":"AS198985 AQUILENET","country_code3":"FRA","asn":198985,"area_code":"0","organization_name":"AQUILENET","country_code":"FR","continent_code":"EU"}] ``` whereas a few hours ago that returned a 500. And now the timestamps are different ``` ;; from schema "2021-03-18T19:52:41.808482Z" ;; results "2021-03-18T20:52:41.808482+01:00" ``` kinda sick of dealing with this and don't want to deal with a schema that matches "near" to a timestamp. * Restore these i copied changes over from tim's fix and it included these fixes. But now the service is fixed and these are the original values from cam's original fixes * ping CI * [CI, E2E] Fix revision history flake (metabase#30757) (metabase#30759) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * cherry pick - fix selecting pinned items in collections (metabase#30653) (metabase#30774) * fix selecting pinned items in collections * update e2e test * Manual backport "Fix custom mapping doesn't work on dashboard" (metabase#30683) * Fix custom mapping doesn't work on dashboard (metabase#30217) * Keep original join-aliases in expected columns (metabase#30747) (metabase#30762) * Keep original join-aliases in expected columns Fixes metabase#30648. The root cause of the bug was that the result_metadata generated for MBQL queries returned escaped join-aliases, which in BigQueries case means that spaces are converted underscores (_). These wrong join aliases could not be resolved in later stages and resulted in incorrect references. Normally, the escaped aliases are replaced by original ones in the post processing step, but the post processing is not executed when calculating expected columns. This PR makes sure the original aliases are restored in the expected columns. * Keep source_alias and display_name intact too Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Repro metabase#30743: Sorting on the breakout column in joined questions crashes (metabase#30755) (metabase#30786) [ci skip] * Upgrade `xlsx` (metabase#30781) (metabase#30788) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Remove millisecond unit from datetimeDiff docs (metabase#30749) (metabase#30810) Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> * Adds encoding to field props for database inputs (metabase#30812) (metabase#30818) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Backport SQL snippets fix to 46 (metabase#30852) * reduce revision history flakes? (metabase#30861) (metabase#30862) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * Fix sample database not appearing in Database Browser without page refresh (metabase#30871) (metabase#30878) * Fix sample database not appearing in DatabaseBrowser without page refresh - Fixes metabase#29496 * Add an e2e test for metabase#30871 * Add an extra step in e2e test Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Exclude :starburst from two-of-the-same-aggregations-test (metabase#30830) (metabase#30883) This test requires the DB to support nested order by clauses which Trino does not. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Handle rubbish in mongodb versionArray (metabase#30879) (metabase#30881) Fixes metabase#29678. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * [E2E] Skip super flaky revision history test (metabase#30919) (metabase#30930) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * Updates Postgres format-interval to accept decimal numbers (metabase#30849) (metabase#30912) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * docs - update release list (metabase#30955) (metabase#30958) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Remove activity (metabase#29056) (metabase#30952) * Remove activity (metabase#29056) * remove activity frontend * remove the activity page code * remove GET api/activity/ route + tests * regen dox for activity routes - Not for GET /api/activity/ which has been removed. * nix more things only used for GET /api/activity/ * pull out more only-used-for-get-api/activity/ code * force namespace to be loaded (?) to be found --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> * fix ns requires in api/activity + test * remove most-recently-viewed-dashboard-views-test * linter fix --------- Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> * Fixed MB_JETTY_PORT env var (metabase#30954) (metabase#30973) Co-authored-by: Roman Abdulmanov <roman@metabase.com> * 🍒 Backport pre-release improvements (metabase#30972) * CI: Prerelease workflow improvements (metabase#30819) - Abort if the intended version conflicted with a past release - Bail out if the commit hash isn't part of a release branch * CI prerelease workflow: pretend to be the intended version (metabase#30915) --------- Co-authored-by: Ariya Hidayat <ariya@metabase.com> * Use display name from model for implicit actions (metabase#30356) (metabase#30501) * Use display name from card for implicit actions * Remove fields arg from generateFieldSettingsFromParameters * Update implicit action test to include display-name * Tidy * Fix unit tests * Fix e2e test * Only include display-name in the parameters for implicit action types * Use `field.displayName()` * Fix some tests * Attempt to fix test * Fix ActionParametersInputForm unit tests * Only generate field settings from parameters if action.type is implicit * Fix e2e tests * Fix unit tests * Fix tests Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> * Manual backport: Fix Add Series modal performance issues by moving the logic to the BE (metabase#30971) * backport 30321 with lots of custom code that take from 47 * rm src/metabase/lib/isa.clj * fix isa_test * docs - note on sandboxing and optional parameters (metabase#30936) (metabase#30982) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Backport recent_views in user-local settings (metabase#29631) to 46 release branch (metabase#30965) * recent_views stored in user local setting (metabase#29631) * First pass at recent_views stored in user local setting This modifies the view log event handler to write a user's views to their local settings map (stored as json in the appdb). some notes on what causes a view :card-query - occurs when collection with pinned cards/models is opened. maybe shouldn't count as a view :card-read - happens when you view a card, like, load it in the UI and are looking at it :card-read AND :card-query - happens when you view a model, like, load it in the UI and are looking at it :dashboard-read - happens when you view a dashboard :card-create - when you save a card - this will probably cause double counts because it will save and then trigger a :card-read right away too :table-read - when viewing a table. - when selecting a db/table in dropdowns in the Question editor I think we need the view log topics to be much smaller: #{:card-read :dashboard-read :table-read} * WIP test for the recent_views user local setting. This isn't totally correct yet. I think it doesn't clean up after itself correctly. That's pending. And, I have to investigate because :table-read isn't working either. Still worth pushing this progress! * Test that works! All potential view events need :actor_id * Working test for /api/recent_views * Order of views in user-local recent-views works now If a user views something they've recently viewed, the homepage order doesn't change. Now it will, as in, the most recently viewed item will always be the first item in the vector. * One time recent_views expensive query done in the user-recent-views getter The logic of filling the recent-views setting was first written in the activity api namespace. Now it's handled where the setting is defined, which lets anyone else consuming the setting not worry about filling it if its empty. The setting can be reset with `nil` which will cause the query to run again. Otherwise, if the list of recent items is an empty vector, that is considered valid and will not re-run the query. Updating the setting per view is handled still in the view log handler, implemented in the private function `update-users-recent-views!`. * Add `most-recently-viewed-dashboard` setting The most recently viewed dashboard for that user, in the past 24 hours. This is not meant to be a permanent solution to providing this bit of info for the user, rather, it's a 'stop gap' while the audit tables are reworked. * Add test for most recent dashboard setting * Pass :context to the view log fns This lets us filter out views triggered by pinned cards. * Fix tests failing after adding :context to view metadata * See if card-query can help us filter out pinned item views * Tests should send :card-query events * Since we use :card-query, we have to filter out dashboard context too This should prevent views being recorded if someone just opens a dashboard. * ViewLog Cleanup to see if it'll let other tests pass * fix build * clean ns and fix build --------- Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com> * Embedded link cards (metabase#30917) (metabase#30985) * open metabase links in same iFrame when embedding * unit test link behavior Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * max retention env var (metabase#30943) (metabase#30993) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by: metabase-bot[bot] <109303359+metabase-bot[bot]@users.noreply.github.com> Co-authored-by: Natalie <nat@metabase.com> Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> Co-authored-by: dpsutton <dan@dpsutton.com> Co-authored-by: Tim Macdonald <tim@metabase.com> Co-authored-by: Ariya Hidayat <ariya@metabase.com> Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by: Kartikeya <42073497+fathomer@users.noreply.github.com> Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Roman Abdulmanov <roman@metabase.com> Co-authored-by: Case Nelson <case@metabase.com> Co-authored-by: Emmad Usmani <emmadusmani@berkeley.edu> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Maiquu
pushed a commit
to Maiquu/metabase
that referenced
this issue
Jun 14, 2023
…fresh (metabase#30871) (metabase#30878) * Fix sample database not appearing in DatabaseBrowser without page refresh - Fixes metabase#29496 * Add an e2e test for metabase#30871 * Add an extra step in e2e test Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
chalenge
added a commit
to faros-ai/metabase
that referenced
this issue
Jul 3, 2023
* docs - update notification permissions (metabase#29845) (metabase#29865) Co-authored-by: Natalie <nat@metabase.com> * Backport 9b8ac70 (metabase#29860) * Fix can't join a table with another native question based on the same table (metabase#29879) (metabase#29880) * Convert timezone used to works for redshift, not sure why it's suddenly (metabase#29883) (metabase#29899) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * Fixes convert-timezone tests for redshift (metabase#29923) (metabase#29933) Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> * [E2E] Add back `Vertica` assertion (metabase#29972) (metabase#29980) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Fix typo in managing-people-groups doc (metabase#29878) (metabase#29992) f -> of Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * update help text for serialization commands (metabase#29993) * [Docs] Fix "Asking questions" introduction (metabase#30032) (metabase#30033) * Update the position description of "clear all filters" * Add missing links to `models` page Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * note on mongo scans (metabase#30017) (metabase#30038) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - note on invitations (metabase#30049) (metabase#30079) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - update saml (metabase#29846) (metabase#30088) Co-authored-by: Natalie <nat@metabase.com> * docs - update full-app embedding (metabase#30085) (metabase#30092) Co-authored-by: Natalie <nat@metabase.com> * Fix not being able to use field filters in databases without schema (metabase#30029) (metabase#30070) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * Cherry-pick c7eb725 (metabase#30118) * [DOCS] Update editing user account instructions (metabase#30135) (metabase#30148) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * docs - break out charts into individual pages (metabase#30129) (metabase#30154) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Removes action_id from v1 dump. Resolves metabase#29528 (metabase#29541) (metabase#30158) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Fix serdes v2 entity id backfill (metabase#29808) (metabase#30159) * Fixes backfill-ids/has-entity-id? * Adds hydration for Action :model * Adds test for Action :model hydration Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * docs - update session expiration, google sign-in, and env vars (metabase#30188) (metabase#30198) Co-authored-by: Natalie <nat@metabase.com> * Include checklist task to migrate off h2 (metabase#30126) (metabase#30210) * Include checklist task to migrate off h2 New checklist item is shown when not hosted and app-db is h2. A divergence from others, this checklist is not shown if it is not triggered. In other words, we don't want to show this task as completed in the UI if they are hosted or using pg, we just want to omit the task completely. This is because we do not know if they upgraded or just started with pg/mysql or started in the cloud. Did lots of cleanup to make this easier to grok and easier to test. Ultimately we don't have to redef a bunch of stuff to test the scenarios. * Fix setup links for external urls * Re-export * Add api types * Add tests * Improve tests * Improve tests * Improve tests * Improve tests * Improve tests * Simplify if * Show checklist as completed when on pg/mysql and not hosted was filtering this out as we can't (easily?) tell if an instance was migrated from h2 -> postgres. So wasn't clear if showing a checked-off task list item made sense. But it does. So we'll show it. We just wont' show it in cloud (hosted) --------- Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * 🍒 Backport Percy fixes and changes (metabase#30192) * [TEMP] Disable the failing Percy spec (metabase#30175) * Increase the request timeout for Percy model editor spec (metabase#30176) * Increase the request timeout for Percy model editor spec * Update e2e/test/visual/models/editor.cy.spec.js Co-authored-by: Tim Macdonald <tim@metabase.com> --------- Co-authored-by: Tim Macdonald <tim@metabase.com> * [CI] Remove matrix strategy from the `percy` job (metabase#30153) * Upgrade Percy CLI to `v1.23.0` (metabase#30179) --------- Co-authored-by: Tim Macdonald <tim@metabase.com> * [DOCS] Fix typo in premium features overview (metabase#30225) (metabase#30228) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Release automation: publish Elastic Beanstalk artifacts (metabase#28516) (metabase#30233) The core logic is still from the release script in bin/release. The change here mostly wiring it up to GitHub Action so that it can be trigged upon a new git tag (during the release process). Co-authored-by: Ariya Hidayat <ariya@metabase.com> * docs - update filters troubleshooting guide (metabase#30203) (metabase#30238) Co-authored-by: Natalie <nat@metabase.com> * docs - update "can't see tables" troubleshooting guide (metabase#30215) (metabase#30239) Co-authored-by: Natalie <nat@metabase.com> * docs - update official collection info (metabase#30231) (metabase#30240) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * update note on plans (metabase#30258) (metabase#30263) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix metric tool-tip description overflow (metabase#30271) (metabase#30279) Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> * fix anchor link (metabase#30276) (metabase#30286) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix inlined number params in native queries (metabase#30265) (metabase#30287) * Fixes inlining of numeric params in native queries * Updates namespaces to use sql.qp/with-driver-honey-sql-version Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Hide multiple values option when connect dashboard filter with question with template tags (metabase#30270) (metabase#30288) * fix typo * driveby type improvement * Fix not showing single or multiple values options When a parameter is connected to a question with template tags * Review: unit tests instead Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * docs - update link and image (metabase#30296) (metabase#30297) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - updates docs home image (metabase#30298) (metabase#30304) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Wait for db delete request to resolve before closing modal (metabase#30194) (metabase#30320) * wait for db delete request to resolve before closing modal * more async shenanigans # Conflicts: # frontend/src/metabase/admin/databases/database.js * [E2E] Fix question moderation flake (metabase#30252) (metabase#30272) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Generate unique aliases for operations in aggregations (metabase#30302) (metabase#30328) Fixes metabase#30262. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * docs - update env vars (metabase#30341) (metabase#30342) Co-authored-by: Natalie <nat@metabase.com> * Manual backport Do not record revision if the object is not changed. (metabase#30285) (metabase#30346) * Do not record revision if the object is not changed. (metabase#30285) * add week (metabase#30358) (metabase#30362) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * add athena example policy (metabase#30359) (metabase#30363) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * bump snowflake to 3.13.30 (metabase#30336) (metabase#30339) Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> * docs - add db privileges, update db connection troubleshooting (metabase#30205) (metabase#30369) Co-authored-by: Natalie <nat@metabase.com> * Fix typo in password reset email template (metabase#30348) (metabase#30388) * Fix typo in password_reset.mustache * Rename "becase" to "because" [ci skip] Co-authored-by: Kartikeya <42073497+fathomer@users.noreply.github.com> * docs - note on column visibility (metabase#30405) (metabase#30414) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix values source modal not handling not having access to the root collection (metabase#30384) (metabase#30393) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * Solve flakiness on FormCreator unit test (metabase#29474) (metabase#29870) Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> * docs - fix links (metabase#30432) (metabase#30436) * update link * link Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - script and docs for list of releases (metabase#30403) (metabase#30442) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Update filters.md (metabase#30443) (metabase#30447) Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> * fix link (metabase#30449) (metabase#30450) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix metabase#28973: Disable drag for single fields (metabase#30408) (metabase#30448) * disable drag for single fields * refactor isDragDisabled expression * prevent sub-dimension draggability for sub-dimensions with only 1 item * refactor drag and drop conditionals Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> * remove file (metabase#30451) (metabase#30452) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * fix database info banner link (metabase#30330) (metabase#30428) Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> * Fix metabase#25637: SmartScalars should compactify like Scalars (metabase#30337) (metabase#30427) * copy compact logic from scalar * re-organize compactify logic * move duplicated logic into utils file * move scalarUtils * convert scalar_utils to typescript * add smartscalar unit tests for compactify * add unit tests for compactifyValue * refactor optional parameter * default to compact = false for fullScalarValue * refactor scalar_utils unit tests * 20911 include subcollections permissions (metabase#30426) (metabase#30495) Fix metabase#20911: include subcollections doesn't work Co-authored-by: Roman Abdulmanov <roman@metabase.com> * Manual backport: Fix v1 dump command error when logging entities (metabase#30463) (metabase#30498) Updates v1 dump name-for-logging function to handle Toucan 2 records * Remove CircleCi integration (metabase#30493) (metabase#30526) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Fix metabase#30494: fix subcollection apply logic (metabase#30531) (metabase#30544) Co-authored-by: Roman Abdulmanov <roman@metabase.com> * Escape schema and table names in Snowflake JDBC metadata calls (metabase#30537) (metabase#30548) Fixes metabase#26054. The Snowflake JDBC driver is buggy: schema and table name are interpreted as patterns in DatabaseMetaData.getPrimaryKeys and DatabaseMetaData.getImportedKeys calls. This PR replaces the default JDBC functions with ones that escape the names. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Specify baseUrl for e2e tests (metabase#30520) * docs - slack channel renaming note (metabase#30582) (metabase#30589) * slack channel renaming note * note on alerts Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * docs - update postgres (metabase#30592) (metabase#30607) Co-authored-by: Natalie <nat@metabase.com> * docs - update sso (metabase#30608) * Repro metabase#30535: User session affects embedded question (metabase#30591) (metabase#30595) [ci skip] * don't allow pinned collection card overflow (metabase#30612) (metabase#30618) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * Fixes IP geocoding test (metabase#30605) (metabase#30623) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Ignore Twitter links in markdown link checker (metabase#30621) (metabase#30626) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * docs - update alert docs (metabase#30625) (metabase#30627) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Expand `EntityMenuItem` component test coverage (metabase#30615) (metabase#30636) * Do not render menu item that has both `action` and `link` props * Add unit tests * Address PR comment and refactor tests Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Don't lint non-SSL links either (metabase#30633) (metabase#30641) Co-authored-by: Tim Macdonald <tim@metabase.com> * Don't sandbox embedded queries (metabase#30628) (metabase#30652) * initial fix * unskip repro * use as-admin in more places * macro tweak and unit tests * tweak macro again and add a sandboxing test * fix test * docs - rewrite data sandboxes (metabase#30445) (metabase#30682) Co-authored-by: Natalie <nat@metabase.com> * fix links (metabase#30702) (metabase#30704) Co-authored-by: Natalie <nat@metabase.com> * 🤖 backported "Ignore provided metadata on new cards" (metabase#30649) * Ignore provided metadata on new cards (metabase#30640) * Ignore provided metadata on new cards Fixes metabase#30610 Removed an optimization that was put in place for copying cards that trusted the front end to pass in the correct result_metadata. Now, on new cards we ignore the passed in metadata and recalculate fresh. On models, however, we recalculate fresh metadata and combine it with the provided metadata. * Update test based on PR feedback * Fix backported toucan v toucan2 model ref --------- Co-authored-by: Case Nelson <case@metabase.com> * docs - update data sandbox examples (metabase#30733) (metabase#30736) Co-authored-by: Natalie <nat@metabase.com> * docs - update sandboxes some more (metabase#30738) (metabase#30740) Co-authored-by: Natalie <nat@metabase.com> * [CI] Fix syntax error in slack notifications script (metabase#30660) (metabase#30734) # Conflicts: # .github/workflows/rerun-workflows.yml * docs - pro links (metabase#30742) (metabase#30744) * add links to paid features section * add readme link * update links Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Alternative GEOJSON.io fix (metabase#30675) (metabase#30696) * Alternative GEOJSON.io fix (metabase#30675) * Alternative GEOJSON.io fix rather than not testing, just accept that we might get an expected location back or we might get nil. This actually represents how the application will behave and will seamlessly work as the service improves or continues throwing errors: ```shell ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23" <html> <head><title>500 Internal Server Error</title></head> <body> <center><h1>500 Internal Server Error</h1></center> <hr><center>openresty</center> </body> </html> ❯ curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73" [{"area_code":"0","organization_name":"GOOGLE","country_code":"US", "country_code3":"USA","continent_code":"NA","ip":"8.8.8.8", "region":"California","latitude":"34.0544","longitude":"-118.2441", "accuracy":5,"timezone":"America\/Los_Angeles","city":"Los Angeles", "organization":"AS15169 GOOGLE","asn":15169,"country":"United States"}, {"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US", "country_code3":"USA","continent_code":"NA","ip":"136.49.173.73", "region":"Texas","latitude":"30.2423","longitude":"-97.7672", "accuracy":5,"timezone":"America\/Chicago","city":"Austin", "organization":"AS16591 GOOGLE-FIBER","asn":16591,"country":"United States"}] ``` Changes are basically ```clojure (schema= (s/conditional some? <original-expectation-schema> nil? (s/eq nil) response-from-geojson) ``` * Filter to login error messages ```clojure (into [] (map (fn [[log-level error message]] [log-level (type error) message])) error-messages-captured-in-test) [[:error clojure.lang.ExceptionInfo "Error geocoding IP addresses {:url https://get.geojs.io/v1/ip/geo.json?ip=127.0.0.1}"] [:error clojure.lang.ExceptionInfo "Authentication endpoint error"]] ``` * check timestamps with regex seems like they fixed the service ```shell curl "https://get.geojs.io/v1/ip/geo.json?ip=8.8.8.8,136.49.173.73,185.233.100.23" [{"country":"United States","latitude":"34.0544","longitude":"-118.2441","accuracy":5,"timezone":"America\/Los_Angeles","ip":"8.8.8.8","organization":"AS15169 GOOGLE","country_code3":"USA","asn":15169,"area_code":"0","organization_name":"GOOGLE","country_code":"US","city":"Los Angeles","continent_code":"NA","region":"California"},{"country":"United States","latitude":"30.2423","longitude":"-97.7672","accuracy":5,"timezone":"America\/Chicago","ip":"136.49.173.73","organization":"AS16591 GOOGLE-FIBER","country_code3":"USA","asn":16591,"area_code":"0","organization_name":"GOOGLE-FIBER","country_code":"US","city":"Austin","continent_code":"NA","region":"Texas"},{"country":"France","latitude":"48.8582","longitude":"2.3387","accuracy":500,"timezone":"Europe\/Paris","ip":"185.233.100.23","organization":"AS198985 AQUILENET","country_code3":"FRA","asn":198985,"area_code":"0","organization_name":"AQUILENET","country_code":"FR","continent_code":"EU"}] ``` whereas a few hours ago that returned a 500. And now the timestamps are different ``` ;; from schema "2021-03-18T19:52:41.808482Z" ;; results "2021-03-18T20:52:41.808482+01:00" ``` kinda sick of dealing with this and don't want to deal with a schema that matches "near" to a timestamp. * Restore these i copied changes over from tim's fix and it included these fixes. But now the service is fixed and these are the original values from cam's original fixes * ping CI * [CI, E2E] Fix revision history flake (metabase#30757) (metabase#30759) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * cherry pick - fix selecting pinned items in collections (metabase#30653) (metabase#30774) * fix selecting pinned items in collections * update e2e test * Manual backport "Fix custom mapping doesn't work on dashboard" (metabase#30683) * Fix custom mapping doesn't work on dashboard (metabase#30217) * Keep original join-aliases in expected columns (metabase#30747) (metabase#30762) * Keep original join-aliases in expected columns Fixes metabase#30648. The root cause of the bug was that the result_metadata generated for MBQL queries returned escaped join-aliases, which in BigQueries case means that spaces are converted underscores (_). These wrong join aliases could not be resolved in later stages and resulted in incorrect references. Normally, the escaped aliases are replaced by original ones in the post processing step, but the post processing is not executed when calculating expected columns. This PR makes sure the original aliases are restored in the expected columns. * Keep source_alias and display_name intact too Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Repro metabase#30743: Sorting on the breakout column in joined questions crashes (metabase#30755) (metabase#30786) [ci skip] * Upgrade `xlsx` (metabase#30781) (metabase#30788) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Remove millisecond unit from datetimeDiff docs (metabase#30749) (metabase#30810) Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> * Adds encoding to field props for database inputs (metabase#30812) (metabase#30818) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * Backport SQL snippets fix to 46 (metabase#30852) * reduce revision history flakes? (metabase#30861) (metabase#30862) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * Fix sample database not appearing in Database Browser without page refresh (metabase#30871) (metabase#30878) * Fix sample database not appearing in DatabaseBrowser without page refresh - Fixes metabase#29496 * Add an e2e test for metabase#30871 * Add an extra step in e2e test Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * Exclude :starburst from two-of-the-same-aggregations-test (metabase#30830) (metabase#30883) This test requires the DB to support nested order by clauses which Trino does not. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * Handle rubbish in mongodb versionArray (metabase#30879) (metabase#30881) Fixes metabase#29678. Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> * [E2E] Skip super flaky revision history test (metabase#30919) (metabase#30930) Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * Updates Postgres format-interval to accept decimal numbers (metabase#30849) (metabase#30912) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * docs - update release list (metabase#30955) (metabase#30958) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Remove activity (metabase#29056) (metabase#30952) * Remove activity (metabase#29056) * remove activity frontend * remove the activity page code * remove GET api/activity/ route + tests * regen dox for activity routes - Not for GET /api/activity/ which has been removed. * nix more things only used for GET /api/activity/ * pull out more only-used-for-get-api/activity/ code * force namespace to be loaded (?) to be found --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> * fix ns requires in api/activity + test * remove most-recently-viewed-dashboard-views-test * linter fix --------- Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> * Fixed MB_JETTY_PORT env var (metabase#30954) (metabase#30973) Co-authored-by: Roman Abdulmanov <roman@metabase.com> * 🍒 Backport pre-release improvements (metabase#30972) * CI: Prerelease workflow improvements (metabase#30819) - Abort if the intended version conflicted with a past release - Bail out if the commit hash isn't part of a release branch * CI prerelease workflow: pretend to be the intended version (metabase#30915) --------- Co-authored-by: Ariya Hidayat <ariya@metabase.com> * Use display name from model for implicit actions (metabase#30356) (metabase#30501) * Use display name from card for implicit actions * Remove fields arg from generateFieldSettingsFromParameters * Update implicit action test to include display-name * Tidy * Fix unit tests * Fix e2e test * Only include display-name in the parameters for implicit action types * Use `field.displayName()` * Fix some tests * Attempt to fix test * Fix ActionParametersInputForm unit tests * Only generate field settings from parameters if action.type is implicit * Fix e2e tests * Fix unit tests * Fix tests Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> * Manual backport: Fix Add Series modal performance issues by moving the logic to the BE (metabase#30971) * backport 30321 with lots of custom code that take from 47 * rm src/metabase/lib/isa.clj * fix isa_test * docs - note on sandboxing and optional parameters (metabase#30936) (metabase#30982) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Backport recent_views in user-local settings (metabase#29631) to 46 release branch (metabase#30965) * recent_views stored in user local setting (metabase#29631) * First pass at recent_views stored in user local setting This modifies the view log event handler to write a user's views to their local settings map (stored as json in the appdb). some notes on what causes a view :card-query - occurs when collection with pinned cards/models is opened. maybe shouldn't count as a view :card-read - happens when you view a card, like, load it in the UI and are looking at it :card-read AND :card-query - happens when you view a model, like, load it in the UI and are looking at it :dashboard-read - happens when you view a dashboard :card-create - when you save a card - this will probably cause double counts because it will save and then trigger a :card-read right away too :table-read - when viewing a table. - when selecting a db/table in dropdowns in the Question editor I think we need the view log topics to be much smaller: #{:card-read :dashboard-read :table-read} * WIP test for the recent_views user local setting. This isn't totally correct yet. I think it doesn't clean up after itself correctly. That's pending. And, I have to investigate because :table-read isn't working either. Still worth pushing this progress! * Test that works! All potential view events need :actor_id * Working test for /api/recent_views * Order of views in user-local recent-views works now If a user views something they've recently viewed, the homepage order doesn't change. Now it will, as in, the most recently viewed item will always be the first item in the vector. * One time recent_views expensive query done in the user-recent-views getter The logic of filling the recent-views setting was first written in the activity api namespace. Now it's handled where the setting is defined, which lets anyone else consuming the setting not worry about filling it if its empty. The setting can be reset with `nil` which will cause the query to run again. Otherwise, if the list of recent items is an empty vector, that is considered valid and will not re-run the query. Updating the setting per view is handled still in the view log handler, implemented in the private function `update-users-recent-views!`. * Add `most-recently-viewed-dashboard` setting The most recently viewed dashboard for that user, in the past 24 hours. This is not meant to be a permanent solution to providing this bit of info for the user, rather, it's a 'stop gap' while the audit tables are reworked. * Add test for most recent dashboard setting * Pass :context to the view log fns This lets us filter out views triggered by pinned cards. * Fix tests failing after adding :context to view metadata * See if card-query can help us filter out pinned item views * Tests should send :card-query events * Since we use :card-query, we have to filter out dashboard context too This should prevent views being recorded if someone just opens a dashboard. * ViewLog Cleanup to see if it'll let other tests pass * fix build * clean ns and fix build --------- Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com> * Embedded link cards (metabase#30917) (metabase#30985) * open metabase links in same iFrame when embedding * unit test link behavior Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> * max retention env var (metabase#30943) (metabase#30993) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * update release list (metabase#30995) (metabase#30998) Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Fix missing confirmation when running an action without parameters in dashboards (metabase#31058) (metabase#31062) * Add a test case for metabase#28981 * Always open ActionParametersInputModal when clicking an action - update unit tests to reflect this behavior Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> * docs - update public links (metabase#31045) (metabase#31084) Co-authored-by: Natalie <nat@metabase.com> * Manual backport 30868 (metabase#31060) * don't try to update recent views if no user-id is passed (metabase#31103) (metabase#31131) Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> * Remove CircleCI example from E2E dev guide (metabase#31129) (metabase#31139) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Fix system time in `parameters/utils/mbql` tests (metabase#31123) (metabase#31125) Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com> * [CI] Improve FE sources glob pattern to exclude unit tests (metabase#30639) (metabase#31141) * Fix Zoom drill doesn't work with joined fields (metabase#31117) (metabase#31138) This is because `source-field` was missing from a field dimension. * Manual Backport of metabase#31102 (metabase#31152) Manual Backport of metabase#31102 * Fix not able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled (metabase#30976) (metabase#31061) * Fix not being able to Enable/Disable Actions when Choose when syncs and scans happen is Enabled * Fix test Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> * docs - fix typo in db privileges (metabase#31085) (metabase#31159) Co-authored-by: Natalie <nat@metabase.com> * docs - update filters (metabase#31101) (metabase#31163) Co-authored-by: Natalie <nat@metabase.com> * Fix basic actions aren't showing in the order of CUD (metabase#31184) (metabase#31191) Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * 🤖 backported "Repro metabase#23293: Retain filter on drill-through with implicit column" (metabase#31193) * Repro metabase#23293: Retain filter on drill-through with implicit column (metabase#31187) The underlying issue was fixed, but we are not sure exactly when. This reproduction should prevent future regressions. * Adjust the test for the release branch --------- Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * [E2E] Chain the custom `icon` command (metabase#31161) (metabase#31195) * Make E2E custom icon command chainable * Refactor E2E helpers We can now chain the `.icon()` command on the previous subject. * Chain `.icon()` on prev subject in all tests * Fix moderation-question test * Reduce number of E2E test retries (metabase#31197) (metabase#31200) [ci skip] * Manual backport - Fix - Cannot run native queries against MongoDB unless explicitly selecting the table (metabase#31111) (metabase#31198) * Update 15946 e2e test - modal() expects ModalContent to be present in DOM, but NativeQuerymodal uses ModalBody directly - add extra check for run button to be enabled * Add `collection` to `NativeQuery` type * Ensure collection is present in dataset query during query conversion * Unskip e2e test for metabase#15946 * Handle string tableId --------- Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com> * [E2E] Chain the custom `button` command (metabase#31196) (metabase#31239) * Make custom `button` command chainable * Chain `.button` directly No need to use `.within()` anymore. We can chain the button command directly because it now receives the previously yielded subject. * Fix collections bulk actions test * Fix webpack dependabot issue (metabase#29431) (metabase#31245) Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> * Fixup Chromatic storybook build timeout (metabase#30798) (metabase#31247) Co-authored-by: Denis Berezin <denis.berezin@metabase.com> * link (metabase#31222) (metabase#31263) Co-authored-by: Natalie <nat@metabase.com> * Updates v1 dump to extract field values in batches of 32K fields (metabase#31265) (metabase#31295) Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * docs - feedback (metabase#31270) (metabase#31308) Co-authored-by: Natalie <nat@metabase.com> * Backport pre release improvements 2nd part (metabase#31305) * CI pre-release: Add sanity check (metabase#31202) * Pre-build the specific version and edition of MB (metabase#31296) Simply invoking `.bin/build.sh` will produce the uberjar without a version. This is why @ariya created metabase#30915 in the first place. But the build script already takes `:version` and `:edition` arguments. That is exactly what this PR is doing rather than manually unzipping the uberjar in order to tweak its `version.properties` file. --------- Co-authored-by: Ariya Hidayat <ariya@metabase.com> * Manual backport - Fix - Native editor buttons are incorrectly rendering on top of model metadata screen (metabase#31142) (metabase#31348) * Manually backport metabase#31142 - Replace createSampleDatabase with createMockDatabase - Add missing metrics, schemas, and segments attributes in EntitiesState type - EntitiesState type has been heavily refactored in master and that version should be used - Tests will will crash without it these set in state.entities * Fix types * 🤖 backported "Remove `it.skip` from test for metabase#15387" (metabase#31279) * Fix mongo nested queries handling (metabase#30877) (metabase#31370) * Fix native source query handling for mongo * Add test for mongo nested native query * Fix mongo `aggregation-at-index` usage * Add test for source query with aggregation and sort * Adjust test for presto and oracle * Add PR suggestions Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com> * Fix `validate-github-release` step (metabase#31379) (metabase#31386) Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> * Updates Snowflake driver to decode uploaded private key file (metabase#31357) (metabase#31412) Updates Snowflake driver to decode uploaded private key file data if necessary Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> * 🍒 Manual Backport metabase#30558 (metabase#31281) * [E2E] Extract `actions` E2E tests to their own group (metabase#31432) (metabase#31458) * Move core actions E2E tests to a separate folder * Run new `actions` E2E group in CI Metabase actions deserve their own E2E group, as the test suite around them is expected to grow. This commit introduces `actions` E2E group to the CI. * [CI] Increase timeout in multiple workflows (metabase#31449) (metabase#31453) We're seeing increasing number of timeouts in CI without any significant changes in the test suite. This could be due to GitHub's runners performance. [ci skip] * 🤖 backported "fix pivot table settings crash when the question is unaggregated" (metabase#31452) * fix pivot table settings crash when the question is unaggregated (metabase#31383) * fix pivot table settings crash when the question is unaggregated * error boundary * fix spec --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com> * dont cache group mappings (metabase#31377) (metabase#31474) Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> * Ensure download perms are properly enforced on dashcards (metabase#31454) (metabase#31492) * enforce download perms on dashcards * fix tests * Release script: exclude EBS artifact publish from manual steps (metabase#31444) (metabase#31502) Co-authored-by: Ariya Hidayat <ariya@metabase.com> * docs - 46.3 api update (metabase#31269) * Manual backport of metabase#31508 (metabase#31552) * Fix sandbox table migrations for invalid perms table (metabase#31508) * fix migrations and add new test * fix migration IDs in test * dont fail migration if FK already exists * rewrite without table aliases to try to fix error on mysql/mariadb * try to rewrite again * revert to prior version of query * another attempt at a rewrite * fix typo * fix typo * bump ci * replace LIKE with = * fix cherry pick conflict * Backport 01a41a5 (metabase#31550) * Manual backport - Respect alphabetical order of collections in "Move" modal (metabase#31355) (metabase#31549) * Backport changes from metabase#31355 - Skip tests because the setup depends on refactoring done in master - See discussion: https://metaboat.slack.com/archives/C505ZNNH4/p1686648256978279 * Remove unused code --------- Co-authored-by: metabase-bot[bot] <109303359+metabase-bot[bot]@users.noreply.github.com> Co-authored-by: Natalie <nat@metabase.com> Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by: john-metabase <92878045+john-metabase@users.noreply.github.com> Co-authored-by: dpsutton <dan@dpsutton.com> Co-authored-by: Tim Macdonald <tim@metabase.com> Co-authored-by: Ariya Hidayat <ariya@metabase.com> Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com> Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by: metamben <103100869+metamben@users.noreply.github.com> Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by: Kartikeya <42073497+fathomer@users.noreply.github.com> Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Roman Abdulmanov <roman@metabase.com> Co-authored-by: Case Nelson <case@metabase.com> Co-authored-by: Emmad Usmani <emmadusmani@berkeley.edu> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by: Bryan Maass <bryan.maass@gmail.com> Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by: Mark Bastian <markbastian@gmail.com> Co-authored-by: Denis Berezin <denis.berezin@metabase.com> Co-authored-by: Luis Paolini <paoliniluis@gmail.com> Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by: Oisin Coveney <oisin@metabase.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
master(pre-47)I think we need to be doing something to mark the previously-fetched list of Databases out of date when we restore the Sample Dataset, so next time it's needed it gets re-fetched
The text was updated successfully, but these errors were encountered: