Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter box in table has horizontal scroll #31339

Closed
ignacio-mb opened this issue Jun 5, 2023 · 2 comments · Fixed by #32119
Closed

Filter box in table has horizontal scroll #31339

ignacio-mb opened this issue Jun 5, 2023 · 2 comments · Fixed by #32119
Assignees
@kamilmielnik
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Milestone
0.47

Comments

@ignacio-mb
Copy link
Contributor

ignacio-mb commented Jun 5, 2023 •
edited

Describe the bug

When filtering a field that has long strings, the filter box creates an unnecessary horizontal scroll.

To Reproduce

  1. Sample database -> People
  2. Password (long strings field): filter by this column
  3. Is: "8bee" or any known value (dont copy and paste)
  4. Horizontal scroll
Screenshot 2023-06-07 at 5 43 39 PM

Expected behavior

No horizontal scroll

Logs

No response

Information about your Metabase installation

v1.46.4

Severity

Minor

Additional context

No response
@ignacio-mb ignacio-mb mentioned this issue Jun 5, 2023
Closed
@paoliniluis paoliniluis added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. Visualization/Tables Raw, summarized, and pivoted tables and removed .Needs Triage labels Jun 6, 2023
@kamilmielnik kamilmielnik self-assigned this Jul 4, 2023
@kamilmielnik
Copy link
Contributor

I can't reproduce this particular issue anymore.
The filter box auto-resizes itself based on its content (screenshot). I tried many resolutions.

The worst I get sometimes is horizontal scrollbar being there when it should not: screenshot. This is a P4 though.

@kamilmielnik
Copy link
Contributor

Almost entirely fixed by #30778 (epic PR: #30273): https://github.com/metabase/metabase/pull/30778/files#diff-89a7618bee1f2fef73cc32c099003ae01e40091305fb1980199340f6a6551a86R158.

I'll submit a PR for the redundant scrollbar, although it is different scrollbar than originally reported: screenshot.

kamilmielnik added a commit that referenced this issue Jul 4, 2023
@kamilmielnik
Fix #31339
bb824a8
kamilmielnik added a commit that referenced this issue Jul 4, 2023
@kamilmielnik
Add an e2e test for the originally reported issue #31339
c770536
@kamilmielnik kamilmielnik mentioned this issue Jul 4, 2023
Merged
kamilmielnik added a commit that referenced this issue Jul 5, 2023
@kamilmielnik
Fix - Filter box in table has horizontal scroll (#32119)
d41d334 
* Fix #31339

* Add an e2e for horizontal scrollbar presence

* Add an e2e test for the originally reported issue #31339

* Remove inline headerCells

* Format tests

* Remove redundant code

* Move tests to table visualization scenarios tests suite
github-actions bot pushed a commit that referenced this issue Jul 5, 2023
@kamilmielnik
Fix - Filter box in table has horizontal scroll (#32119)
2099c16 
* Fix #31339

* Add an e2e for horizontal scrollbar presence

* Add an e2e test for the originally reported issue #31339

* Remove inline headerCells

* Format tests

* Remove redundant code

* Move tests to table visualization scenarios tests suite
@kamilmielnik kamilmielnik added this to the 0.47 milestone Jul 5, 2023
@deploysentinel deploysentinel bot mentioned this issue Jul 5, 2023
Merged
@kamilmielnik kamilmielnik added the .Reproduced Issues reproduced in test (usually Cypress) label Jul 5, 2023
This was referenced Jul 5, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
metabase-bot bot added a commit that referenced this issue Jul 6, 2023
@metabase-bot @kamilmielnik
Fix - Filter box in table has horizontal scroll (#32119) (#32133)
6d93a62 
* Fix #31339

* Add an e2e for horizontal scrollbar presence

* Add an e2e test for the originally reported issue #31339

* Remove inline headerCells

* Format tests

* Remove redundant code

* Move tests to table visualization scenarios tests suite

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilmielnik kamilmielnik

Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Projects
None yet
Milestone
0.47
Development

Successfully merging a pull request may close this issue.

Fix - Filter box in table has horizontal scroll metabase/metabase
4 participants
@paoliniluis @kamilmielnik @ranquild @ignacio-mb