Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV appends Milestone 0, Merge 1 of 2: add endpoint to append to table #36640

Merged
merged 10 commits into from
Dec 22, 2023
Merged

CSV appends Milestone 0, Merge 1 of 2: add endpoint to append to table #36640

merged 10 commits into from
Dec 22, 2023

Conversation

calherries
Copy link
Contributor

@calherries calherries commented Dec 11, 2023 •
edited by iethree
Loading

This is the feature branch for Merge 1 of 2 of Milestone 0

epic
product doc
eng doc

From eng doc (block link):

Eng spec:

  • Create a new endpoint POST /api/table/:id/append-csv
  • Appends the rows in an uploaded CSV file to a table that was created with a CSV upload (the table must have is_upload=true)
  • If the schema matches, inserts the CSV rows to the table. Undo all changes if there are any failures
  • It must work for all drivers that support the “uploads” feature: MySQL, H2, and Postgres

Tasks

Edit tasklist title
Beta Give feedback Tasklist Tasks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. CSV appends: Merge 1, Milestone 0: add endpoint to append to table (part one) #36485
    .Team/BackendComponents
    calherries
    Edit...
  2. CSV appends: Handle _mb_row_id columns #36705
    .Team/BackendComponents
    calherries
    Edit...
  3. CSV appends: Handle type mismatch errors #36826
    .Team/BackendComponents
    calherries
    Edit...
  4. CSV appends: permissions checks #36950
    .Team/BackendComponents
    calherries
    Edit...
  5. CSV appends: better header mismatch error messages #36990
    .Team/BackendComponents
    calherries
    Edit...
  6. CSV appends: Use a transaction for inserting data #36995
    .Team/BackendComponents
    calherries
    Edit...
  7. Append to Model from CSV #37330
    .Team/AdminWebapp
    iethree
    Edit...
Loading

To be implemented later:
#37069

@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label Dec 11, 2023
@calherries calherries added the no-backport Do not backport this PR to any branch label Dec 11, 2023
This was referenced Dec 11, 2023
Merged
Closed
Merged
@calherries calherries mentioned this pull request Dec 14, 2023
Merged
2 tasks
This was referenced Dec 19, 2023
Merged
Merged
Merged
@cypress Cypress
Copy link

cypress bot commented Dec 21, 2023 •
edited
Loading

Passing run #917 ↗︎

0 2198 155 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

CSV appends Milestone 0, Merge 1: add endpoint to append to table
Project: Metabase e2e Commit: deb869b573
Status: Passed Duration: 15:10 💡
Started: Dec 22, 2023 12:48 PM Ended: Dec 22, 2023 1:03 PM

Review all test suite changes for PR #36640 ↗︎

@calherries calherries requested review from luizarakaki and a team December 22, 2023 08:38
@calherries calherries removed the request for review from a team December 22, 2023 12:51
@calherries calherries added this to the 0.49 milestone Dec 22, 2023
@calherries calherries enabled auto-merge (squash) December 22, 2023 14:35
@calherries calherries merged commit f59b18a into master Dec 22, 2023
106 checks passed
@calherries calherries deleted the appends/milestone-0-endpoint branch December 22, 2023 15:04
@calherries calherries changed the title CSV appends Milestone 0, Merge 1: add endpoint to append to table CSV appends Milestone 0, Merge 1 of 2: add endpoint to append to table Jan 3, 2024
@crisptrutski crisptrutski mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizarakaki luizarakaki luizarakaki approved these changes

Assignees

@calherries calherries

Labels
no-backport Do not backport this PR to any branch .Team/BackendComponents also known as BEC
Projects
None yet
Milestone
0.49
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calherries @luizarakaki