Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [BE] Add breakoutColumn and aggregationColumn APIs to simply columns retrieval from these clauses #37120

Closed
Tracked by #36108
ranquild opened this issue Dec 27, 2023 · 0 comments · Fixed by #37873
Closed
Tracked by #36108

[MLv2] [BE] Add breakoutColumn and aggregationColumn APIs to simply columns retrieval from these clauses #37120

ranquild opened this issue Dec 27, 2023 · 0 comments · Fixed by #37873
Assignees
@bshepherdson
Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Milestone
0.49

Comments

@ranquild
Copy link
Contributor

ranquild commented Dec 27, 2023 •
edited 

// currently going from AggregationClause -> ColumnMetadata is non-trivial,
// so let's make a better API for this task
aggregationColumn(
  query: Query,
  stageIndex: number,
  clause: AggregationClause
): ColumnMetadata | null;

// same
breakoutColumn(
  query: Query,
  stageIndex: number,
  clause: BreakoutClause,
): ColumnMetadata
@ranquild ranquild mentioned this issue Dec 27, 2023
Closed
This was referenced Jan 8, 2024
Closed
Closed
@ranquild ranquild added .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench: .Backend labels Jan 8, 2024
@bshepherdson bshepherdson self-assigned this Jan 17, 2024
@bshepherdson bshepherdson added this to the 0.49 milestone Jan 17, 2024
@bshepherdson bshepherdson mentioned this issue Jan 18, 2024
Merged
bshepherdson added a commit that referenced this issue Jan 19, 2024
@bshepherdson
[MLv2] Add aggregation-column and breakout-column (#37873)
7837c71 
These are helpers for going from an aggregation or breakout
clause to the relevant `:metadata/column`. (Nil for top-level
aggregations like `:count`.)

Fixes #37120.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bshepherdson bshepherdson

Labels
.Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
0.49
Development

Successfully merging a pull request may close this issue.

[MLv2] Add aggregation-column and breakout-column metabase/metabase
2 participants
@bshepherdson @ranquild