[MLv2] Add aggregation-column and breakout-column
#37873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
These are helpers for going from an aggregation or breakout clause to the relevant `:metadata/column`. (Nil for top-level aggregations like `:count`.)
bshepherdson
force-pushed
the
mblib-aggregation-breakout-column
branch
from
e4a9905
to
145ad1a
Compare
metamben
approved these changes
Jan 19, 2024
I would argue that "column" is not "field" - if one is doubling a column |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are helpers for going from an aggregation or breakout
clause to the relevant
:metadata/columnthey are based on.Eg. the column being
SUM'd by an aggregation or bucketed by a breakout.(Nil for top-level aggregations like
:count.)Fixes #37120.