-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action Buttons #3737
Comments
Related to #2882 |
This is slightly different to #2882. Instead of outright editing data in a table (which can be potentially dangerous), the user would only be shown pre-created actions which are very specific. |
I think this is a great idea, instead of allowing blank update/edit of everything this would be a much safer appraoch and would allow to have non-technical people run potentially needed update tasks/actions. That would imo make metabase extremely powerful, instead of 'just' being great at analytics (and viewing the underlying data) to also be able to perform very specific crud actions. |
@Globegitter @kevinmartin @tlrobinson - Would you be interested in pair programming, as I'd love to implement this feature? |
I have made a very minimal implementation of something similar. It differs from what’s proposed here by performing a HTTP POST to an API outside Metabase instead of making direct database writes. I think that’s preferable in most cases for a number of reasons (mainly isolation/not having to duplicate business logic). Currently what I have only works for picking points on line/area/bar visualizations as that fit my current needs, though extending it to cover e.g. table row clicks should be trivial. For my current use I post to an open source tool StreamSets which in a no-code solution validates and picks input and updates my backend. I’m up for pairing on getting this into the shape of a mergeable PR (with tests etc.) covering more scenarios. Thoughts? |
I would love the ability to define a button for a row that makes allows me to make an HTTP request using data from the given row and potentially some form of authorization header. Being able to make well defined API requests within Metabase would allow Metabase itself to remain read-only but allow us to define more complex write relationships in our own APIs that we can easily trigger. |
This comment has been minimized.
This comment has been minimized.
@joekh I've implemented what I mentioned above in #3737 (comment) a while back (around v0.27-ish), and it sits on my Metabase fork. Nothing has been merged back to official Metabase. It could be revived. What's your particular use case? Would something similar to what @zolrath mention above cover what you need as well? A related issue #8461 to get peoples minds going about requirements/use cases/UX also just popped in ☝️ |
Hey @jornh, thanks for getting back to me. |
Thanks for the details @joekh - it sounds doable.
Does that sound like sensible steps? If you see anything obvious missing please chime in. |
Hey @jornh! |
The "button" currently available on the graph is actually just a menu item, like: Image stolen from #8461 ... hope it can work on tables as well... Yep, hear you regarding POST'ing the selected object (maybe even selected objects? - can't really remember) as JSON. It's already in there. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as spam.
This comment was marked as spam.
@metabase/success-engineering think we can close this? |
Closing as resolved! 🎉 |
It would be great if, apart from creating questions, segments, and metrics, if we can create actions.
Use case scenarios:
This would be especially great when doing a deep dive on a specific row and its relationships.
Actions would just be queries (usually
INSERT
orUPDATE
) that also accepts variables based on information in the row you're taking action on.⬇️ Please click the 👍 reaction instead of leaving a
+1
orupdate?
commentThe text was updated successfully, but these errors were encountered: