Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Add Extract action to chill mode column headings #38964

Closed
7 tasks done
kamilmielnik opened this issue Feb 20, 2024 · 1 comment
Closed
7 tasks done

[Epic] Add Extract action to chill mode column headings #38964

kamilmielnik opened this issue Feb 20, 2024 · 1 comment
Assignees
@bshepherdson @kamilmielnik @ranquild
Labels
.Epic Feature Implementation or Project .Team/QueryingComponents .Team/QueryProcessor :hammer_and_wrench:
Milestone
0.50

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented Feb 20, 2024 •
edited by bshepherdson

Links

Implementation Plan

Milestone 1 - Date/time columns

Milestone 1 should only cover datetime extractions, specifically the following 6 (see Figma):

  • Hour of day
  • Day of month
  • Day of week
  • Month
  • Quarter
  • Year

Backend
Beta Give feedback
  1. "Extract column" drill thru #39162
    .Team/QueryingComponents no-backport visual
    bshepherdson ranquild
  2. Limit list of temporal units based on the column type #40125
    bshepherdson

Frontend
Beta Give feedback
  1. Date/time column extractions #39248
    .Frontend .Team/QueryingComponents
    kamilmielnik
  2. Extract column e2e #39770
    .Team/QueryingComponents no-backport visual
    ranquild
  3. Make the created column appear to the right of the selected one in table viz #39982
    .Frontend .Team/QueryingComponents
    ranquild

Milestone 2 - URL columns

Splitting up URLs to extract the (sub)domain(s) is not a simple task. There are libraries for it but they're complex, and we can't push those into the data warehouse anyway. I think we'll have to do the best we can with a regexextract so that it can be handled at the database level.

Estimate: 0.5 to 1 day to write and heavily test the regexes; plus a bit to integrate the new type into the column-extract drill.

Backend
Beta Give feedback
  1. [MLv2] Support Extract action for (sub)domains from URLs #40188
    .Team/QueryProcessor no-backport
    bshepherdson

Milestone 3 - Email columns

Extracting the host after the @ is straightfoward. Going from there to the domain can reuse the regex from Milestone 2.

Estimate: 0.5 days to build the email regex and integrate into the column-extract drill.

Backend
Beta Give feedback
  1. [MLv2] Support Extract to get the domain from emails #40200
    no-backport
    bshepherdson
@kamilmielnik kamilmielnik added .Epic Feature Implementation or Project .Team/QueryProcessor :hammer_and_wrench: .Team/QueryingComponents labels Feb 20, 2024
@ranquild ranquild mentioned this issue Feb 26, 2024
Merged
@kamilmielnik kamilmielnik mentioned this issue Mar 12, 2024
Closed
bshepherdson added a commit that referenced this issue Mar 15, 2024
@bshepherdson
[MLv2] Support Extract action for (sub)domains from URLs
ac2355e 
Milestone 2 of #38964.
@bshepherdson bshepherdson mentioned this issue Mar 15, 2024
Merged
bshepherdson added a commit that referenced this issue Mar 15, 2024
@bshepherdson
[MLv2] Support Extract to get the domain from emails
ee6fa24 
Milestone 3 of #38964.
@bshepherdson bshepherdson mentioned this issue Mar 15, 2024
Merged
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract action for (sub)domains from URLs
23b89a0 
Milestone 2 of #38964.
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract to get the domain from emails
2f81cca 
Milestone 3 of #38964.
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract action for (sub)domains from URLs
db5db4f 
Milestone 2 of #38964.
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract to get the domain from emails
3ce100b 
Milestone 3 of #38964.
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract action for (sub)domains from URLs (#40188)
7a4918d 
Milestone 2 of #38964.
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract to get the domain from emails
e0a89ec 
Milestone 3 of #38964.
bshepherdson added a commit that referenced this issue Mar 18, 2024
@bshepherdson
[MLv2] Support Extract to get the domain from emails (#40200)
15a411c 
Milestone 3 of #38964.
@bshepherdson bshepherdson added this to the 0.50 milestone Mar 19, 2024
@bshepherdson
Copy link
Contributor

This has all landed in master and has a 👍 from PMs.

@kamilmielnik kamilmielnik mentioned this issue Apr 12, 2024
Closed
bshepherdson added a commit that referenced this issue Apr 16, 2024
@bshepherdson
[MBQL lib] Column Extract from URL, email requires regex support
1a67215 
Not all drivers support regular expressions. Don't return the
Column Extractions for URL -> (sub)domain and email -> domain unless the
database can support the regular expression matches.

Part of the follow-up for Extract Column epic #38964.
@bshepherdson bshepherdson mentioned this issue Apr 16, 2024
Merged
bshepherdson added a commit that referenced this issue Apr 17, 2024
@bshepherdson
[MBQL lib] Column Extract from URL, email requires regex support (#41484
0bde1fc 
)

Not all drivers support regular expressions. Don't return the
Column Extractions for URL -> (sub)domain and email -> domain unless the
database can support the regular expression matches.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 17, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level
b372656 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
@bshepherdson bshepherdson mentioned this issue Apr 17, 2024
Merged
bshepherdson added a commit that referenced this issue Apr 17, 2024
@bshepherdson
[QP, lib] Add new expression functions for host, domain, subdomain
f107980 
These functions are implemented with hairy regular expressions, and
it's more user-friendly and future-proof to name those functions in MBQL
rather than baking the `regexextract` and regex into the user's query.

It lets us evolve the regexes in the future if we detect a bug, and it
improves the UX since the user sees a meaningful function instead of

    regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)")

Part of the follow-up for Extract Column epic #38964.
@bshepherdson bshepherdson mentioned this issue Apr 17, 2024
Merged
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add new expression functions for host, domain, subdomain
b287a4e 
These functions are implemented with hairy regular expressions, and
it's more user-friendly and future-proof to name those functions in MBQL
rather than baking the `regexextract` and regex into the user's query.

It lets us evolve the regexes in the future if we detect a bug, and it
improves the UX since the user sees a meaningful function instead of

    regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)")

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
4f3a359 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
1e23a8c 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add new expression functions for host, domain, subdomain
f667fb6 
These functions are implemented with hairy regular expressions, and
it's more user-friendly and future-proof to name those functions in MBQL
rather than baking the `regexextract` and regex into the user's query.

It lets us evolve the regexes in the future if we detect a bug, and it
improves the UX since the user sees a meaningful function instead of

    regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)")

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
1c9bbe7 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
f62923e 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
a0b4519 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add new expression functions for host, domain, subdomain (#…
e435824 
…41540)

These functions are implemented with hairy regular expressions, and
it's more user-friendly and future-proof to name those functions in MBQL
rather than baking the `regexextract` and regex into the user's query.

It lets us evolve the regexes in the future if we detect a bug, and it
improves the UX since the user sees a meaningful function instead of

    regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)")

Also refactors the regexes somewhat so that they work for emails as well as URLs, and there's always just one layer of `:regex-match-first`.
Previously this was separated into two steps: URL or email to host, and host to (sub)domain.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
2fc7356 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
48115c0 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 19, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
8328d94 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 22, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
75217b2 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 22, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level
81950fb 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 23, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level
8c011c4 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 23, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level
f484f29 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 23, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level
3a3fff1 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
metamben added a commit that referenced this issue Apr 23, 2024
@metamben @uladzimirdev
@oisincoveney @WiNloSt @kamilmielnik @noahmoss @npfitz @johnswanson @sloansparger @nemanjaglumac @lbrdnk @npretto @alexyarosh @jeff-bruemmer @bshepherdson @tsmacdonald @escherize @rafpaf @puchka @adam-james-v @calherries @piranha @romeovs @iethree
Merge master to metrics v2 (#41738)
1a7e986 
* Add a way to update filter type and operator from parameter sidebar (#41555)

* Convert EmbeddingContext to Sdk Store slice (#41585)

* Add prefix to CSS custom properties (#41574)

* Migrate --border-*

* Migrate *breadcrumb*

* Migrate --color-bg-black

* Migrate --color-bg-dark

* Migrate --color-bg-light

* Migrate --color-bg-medium

* Migrate --color-bg-white

* Migrate --color-border

* Migrate --color-brand*

* Migrate --color-error

* Migrate --color-focus

* Migrate --color-shadow

* Migrate --color-success

* Migrate --color-text-dark

* Migrate --color-text-light

* Migrate --color-text-medium

* Migrate --color-text-white

* Migrate --color-white

* Migrate --default-border-radius

* Migrate --default-button-border-radius

* Migrate --default-font-family

* Migrate --default-font-size

* Migrate --default-header-margin

* Migrate --gap-1

* Migrate --icon-width

* Migrate --input-border-color

* Migrate --input-border-radius

* Migrate --margin-*

* Migrate --muted-color

* Migrate --padding-*

* Migrate --page-header-padding

* Migrate --subtitle-color

* Migrate --title-color

* Reset to master

* Remove unused --color-text-default

* Remove unused --color*

* Remove unused CSS custom properties

* Prefix only necessary CSS custom properties

* Fix Dispatch type (#41631)

* Fix Dispatch type

* Fix typing

* Fix types

* [Feature branch] Split data access and query builder access (#41581)

Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Co-authored-by: John Swanson <john.swanson@metabase.com>
Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
Co-authored-by: Sloan Sparger <sloansparger@gmail.com>

* Re-wire the `Groups` entity to use RTK Query under the hood (#41480)

* Delete unused endpoint from `PermissionsApi`

* Add group tag helpers

* Define RTK Query 5 main endpoints for `permissionApi` (group)

* Re-wire 5 main api methods in groups entity to work with RTK Query

* Re-wire `clearMember` action to work with RTK Query

* Add `Groups.api.update`

* Update types

* Fix membership failing to update after `CREATE_MEMBERSHIP`

* Make sure `members` is not undefined

* Fix cache invalidation

* Use dbname from database details instead of stats returned from Mongo (#41549)

* Use dbname from details instead of from stats

* Add mongo sharded cluster CI job

* add withUndos option to renderWithProviders to render Undos during … (#41576)

* Account for non-hydrated properties in GET /api/dashboard (#41622)

* Account for non-hydrated properties in GET /api/dashboard

* Fix provideTags

---------

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>

* [docs] Revise Okta SAML docs (#41493)

* okta docs

* clarifying group mapping methods

* links

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* review feedback

* Typo

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* Remove defaultauthdb portion of mongo connection string (#41553)

* Reset mapping after change of operator for native questions (#41615)

* Reset mapping after change of operator for native questions

* Add a basic test

* Better name for a test

* Add a new migration to clean up deprecated perm types (#41649)

* [QP, lib] Add new expression functions for host, domain, subdomain (#41540)

These functions are implemented with hairy regular expressions, and
it's more user-friendly and future-proof to name those functions in MBQL
rather than baking the `regexextract` and regex into the user's query.

It lets us evolve the regexes in the future if we detect a bug, and it
improves the UX since the user sees a meaningful function instead of

    regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)")

Also refactors the regexes somewhat so that they work for emails as well as URLs, and there's always just one layer of `:regex-match-first`.
Previously this was separated into two steps: URL or email to host, and host to (sub)domain.

Part of the follow-up for Extract Column epic #38964.

* New default DB permissions (#40869)

* Re-wire the `Revisions` entity to use RTK Query under the hood (#41558)

* Add RTK Query `revision` API

* Re-wire `Revisions` entity `list` to work with RTK Query

* Re-wire the `Revisions` entity `revert` to work with RTK Query

* Rename 'mac' alias to 'macaw' (#41680)

* Fix not sending necessary HTTP headers when downloading results (#41633)

* Fix not sending necessary HTTP headers when downloading results

* Fix fail E2E tests

* Add E2E test

* Fix failed tests

* Fix unit tests

* Fix download on subpath

* Fix unit tests for subpath

* Re-wire the `Snippets` entity to use RTK Query under the hood (#41656)

* Throw for `Snippets.api.delete`

* Add boilerplate `snippet` RTK API

* Add boilerplate RTK-compatibility layer for main `Snippets.api` endpoints

* Add types

* Add cache invalidation

* add validated migration checksums 45 46 47 and 48 (#41662)

* Modify JWT session token logic to use immediate return value from action (#41694)

* Port six collection-related components to TypeScript (#41632)

BaseItemsTable
BaseTableItem
BulkActions
CollectionContentView
CollectionCopyEntityModal
ItemsTable

* [tech debt] Stop using ms/BooleanString and only use ms/BooleanValue (#41390)

* [tech debt] Stop using ms/BooleanString and only use ms/BooleanValue

ms/BooleanString will coerce to a string, and we should probably get rid of it and only ever use ms/BooleanValue which will always coerce to a boolean
We want the coercion layer to give us values that are helpful, and true is more helpful than "true".
So we should remove ms/BooleanString and calls to parseBoolean

* Remove ms/BooleanString usage in api/native_query_snippet.clj

* Remove test case related to ms/BooleanString

* Remove the BooleanString schema def as no longer used

* Dates Binned by Week Export Formatting Matches App (#41619)

* Dates Binned by Week Export Formatting Matches App

Fixes: #41492

Before, the dates binned by week would be formatted as follows in CSV and JSON exports:

`Week 1 - 2024`

But that doesn't match the App's format of a Date Range:

`January 1, 2024 - January 7, 2024`

So, now the exports will apply formatting in this same way.

Note that a second bug (#41616) exists on the Frontend preventing the column formatting being applied in the app. This is
frontend only, and the csv and json exports will match the column formatting settings (eg. abbreviated dates and
alternative separators will be used in the export).

* add test and change default week style

* Week format test change

* also fix incorrect :hour formatting

* New default permissions for groups (#41323)

* Add dynamic fonts to embedding SDK (#41179)

* Fix TippyPopover default text color not visible after migration (#41716)

* Use the proper case for a "year" token format (#41715)

* Use proper case for year date format

Fixes #40493

* Add regression test for specific filters in different locales

* Actually use the locale

* Note the format_rows changes in the api changelog (#41268)

* Improve test coverage for describe-fks and describe-fields (#41528)

* Exclude internal content from admin checklist and usage stats (#41697)

* Replace `isLoggedIn` and `isInitialized` with `LoginStatus` (#41637)

* move cache business logic to model from api (#41677)

* Migrate Entity Copy Modal away from EntityForm (#41534)

* CopyQuestionForm

* CopyDashboardForm

* inital values adjustment, e2e tests

* FormObserver

* Remove unused `monospaceText` prop (#41721)

* Remove unused function (#41720)

* Be more consistent with borders and avoid double borders (#41565)

* Be more consistent with borders and avoid double borders

* Mark the aggregation 'Custom Expression' button as an action

* Remove color from action headers

* Remove bottom border from last child

* Remove top border from first child

* Make section header classes consistent

* Add border to search header

* Use correct color for borders

* Add props to enable borders in AccordionList

* Add borders to column picker elements

* dont use buildjet for e2e or frontend tests (#41733)

* dont use buildjet for e2e

* dont use buildjet for frontend either

---------

Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
Co-authored-by: Oisin Coveney <oisin@metabase.com>
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Co-authored-by: John Swanson <john.swanson@metabase.com>
Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
Co-authored-by: Sloan Sparger <sloansparger@gmail.com>
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>
Co-authored-by: Nicolò Pretto <info@npretto.com>
Co-authored-by: Alex Yarosh <alexandra@metabase.com>
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Co-authored-by: Braden Shepherdson <braden@metabase.com>
Co-authored-by: Tim Macdonald <tim@metabase.com>
Co-authored-by: bryan <bryan.maass@gmail.com>
Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>
Co-authored-by: A. Marius Rabenarivo <mariusrabenarivo@gmail.com>
Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>
Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com>
bshepherdson added a commit that referenced this issue Apr 23, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
9323af0 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
romeovs pushed a commit that referenced this issue Apr 24, 2024
@bshepherdson @romeovs
[MBQL lib] Add column-extractions to the top level
d37c6cd 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
@romeovs romeovs mentioned this issue Apr 24, 2024
Open
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
4459a93 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level
3b34a41 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
734d79a 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
ab6e1e6 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
1a6b702 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[MBQL lib] Add column-extractions to the top level (#41525)
dd9e126 
Column extractions are "canned" expressions based on a column's
type. For example, we might extract the weekday from a temporal column,
or the domain from an email or URL column.

This logic already existed inside the `column-extract` drill; this pulls
it out as a top-level concept, since extractions are also being
integrated into the notebook editor apart from drills.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 25, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
fc1db5c 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 26, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names
6d99da9 
The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Part of the follow-up for Extract Column epic #38964.
bshepherdson added a commit that referenced this issue Apr 26, 2024
@bshepherdson
[QP, lib] Add expression functions for month, quarter, weekday names (#…
a24abae 
…41548)

The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Note that `:day-of-week` and `:month-of-year` are tricky cases for i18n, but there are tests that exercise them thoroughly.

Part of the follow-up for Extract Column epic #38964.
oisincoveney pushed a commit that referenced this issue Apr 26, 2024
@bshepherdson @oisincoveney
[QP, lib] Add expression functions for month, quarter, weekday names (#…
d859c20 
…41548)

The new expressions `:month-name`, `:quarter-name` and `:day-name`
return the (user localized) names for these units, given the
corresponding number.

For example, 4 yields `"Apr"`, `"Q4"` or `"Wednesday"` respectively.

The `column-extract` drill uses these new expressions, rather than
generating its own `:case` clauses for them.

Note that `:day-of-week` and `:month-of-year` are tricky cases for i18n, but there are tests that exercise them thoroughly.

Part of the follow-up for Extract Column epic #38964.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bshepherdson bshepherdson

@kamilmielnik kamilmielnik

@ranquild ranquild

Labels
.Epic Feature Implementation or Project .Team/QueryingComponents .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
0.50
Development

No branches or pull requests
3 participants
@bshepherdson @kamilmielnik @ranquild