Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to metrics v2 #41738

Merged
merged 39 commits into from
Apr 23, 2024
Merged

Merge master to metrics v2 #41738

merged 39 commits into from
Apr 23, 2024

Conversation

metamben
Copy link
Contributor

No description provided.

uladzimirdev and others added 30 commits April 19, 2024 12:01
* Migrate --border-*

* Migrate *breadcrumb*

* Migrate --color-bg-black

* Migrate --color-bg-dark

* Migrate --color-bg-light

* Migrate --color-bg-medium

* Migrate --color-bg-white

* Migrate --color-border

* Migrate --color-brand*

* Migrate --color-error

* Migrate --color-focus

* Migrate --color-shadow

* Migrate --color-success

* Migrate --color-text-dark

* Migrate --color-text-light

* Migrate --color-text-medium

* Migrate --color-text-white

* Migrate --color-white

* Migrate --default-border-radius

* Migrate --default-button-border-radius

* Migrate --default-font-family

* Migrate --default-font-size

* Migrate --default-header-margin

* Migrate --gap-1

* Migrate --icon-width

* Migrate --input-border-color

* Migrate --input-border-radius

* Migrate --margin-*

* Migrate --muted-color

* Migrate --padding-*

* Migrate --page-header-padding

* Migrate --subtitle-color

* Migrate --title-color

* Reset to master

* Remove unused --color-text-default

* Remove unused --color*

* Remove unused CSS custom properties

* Prefix only necessary CSS custom properties
* Fix Dispatch type

* Fix typing

* Fix types
Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
Co-authored-by: John Swanson <john.swanson@metabase.com>
Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
Co-authored-by: Sloan Sparger <sloansparger@gmail.com>
* Delete unused endpoint from `PermissionsApi`

* Add group tag helpers

* Define RTK Query 5 main endpoints for `permissionApi` (group)

* Re-wire 5 main api methods in groups entity to work with RTK Query

* Re-wire `clearMember` action to work with RTK Query

* Add `Groups.api.update`

* Update types

* Fix membership failing to update after `CREATE_MEMBERSHIP`

* Make sure `members` is not undefined

* Fix cache invalidation
…#41549)

* Use dbname from details instead of from stats

* Add mongo sharded cluster CI job
* Account for non-hydrated properties in GET /api/dashboard

* Fix provideTags

---------

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
* okta docs

* clarifying group mapping methods

* links

* Apply suggestions from code review

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>

* review feedback

* Typo

---------

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
* Reset mapping after change of operator for native questions

* Add a basic test

* Better name for a test
…41540)

These functions are implemented with hairy regular expressions, and
it's more user-friendly and future-proof to name those functions in MBQL
rather than baking the `regexextract` and regex into the user's query.

It lets us evolve the regexes in the future if we detect a bug, and it
improves the UX since the user sees a meaningful function instead of

    regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)")

Also refactors the regexes somewhat so that they work for emails as well as URLs, and there's always just one layer of `:regex-match-first`.
Previously this was separated into two steps: URL or email to host, and host to (sub)domain.

Part of the follow-up for Extract Column epic #38964.
* Add RTK Query `revision` API

* Re-wire `Revisions` entity `list` to work with RTK Query

* Re-wire the `Revisions` entity `revert` to work with RTK Query
* Fix not sending necessary HTTP headers when downloading results

* Fix fail E2E tests

* Add E2E test

* Fix failed tests

* Fix unit tests

* Fix download on subpath

* Fix unit tests for subpath
* Throw for `Snippets.api.delete`

* Add boilerplate `snippet` RTK API

* Add boilerplate RTK-compatibility layer for main `Snippets.api` endpoints

* Add types

* Add cache invalidation
BaseItemsTable
BaseTableItem
BulkActions
CollectionContentView
CollectionCopyEntityModal
ItemsTable
…41390)

* [tech debt] Stop using ms/BooleanString and only use ms/BooleanValue

ms/BooleanString will coerce to a string, and we should probably get rid of it and only ever use ms/BooleanValue which will always coerce to a boolean
We want the coercion layer to give us values that are helpful, and true is more helpful than "true".
So we should remove ms/BooleanString and calls to parseBoolean

* Remove ms/BooleanString usage in api/native_query_snippet.clj

* Remove test case related to ms/BooleanString

* Remove the BooleanString schema def as no longer used
* Dates Binned by Week Export Formatting Matches App

Fixes: #41492

Before, the dates binned by week would be formatted as follows in CSV and JSON exports:

`Week 1 - 2024`

But that doesn't match the App's format of a Date Range:

`January 1, 2024 - January 7, 2024`

So, now the exports will apply formatting in this same way.

Note that a second bug (#41616) exists on the Frontend preventing the column formatting being applied in the app. This is
frontend only, and the csv and json exports will match the column formatting settings (eg. abbreviated dates and
alternative separators will be used in the export).

* add test and change default week style

* Week format test change

* also fix incorrect :hour formatting
* Use proper case for year date format

Fixes #40493

* Add regression test for specific filters in different locales

* Actually use the locale
calherries and others added 8 commits April 23, 2024 10:54
* CopyQuestionForm

* CopyDashboardForm

* inital values adjustment, e2e tests

* FormObserver
* Be more consistent with borders and avoid double borders

* Mark the aggregation 'Custom Expression' button as an action

* Remove color from action headers

* Remove bottom border from last child

* Remove top border from first child

* Make section header classes consistent

* Add border to search header

* Use correct color for borders

* Add props to enable borders in AccordionList

* Add borders to column picker elements
* dont use buildjet for e2e

* dont use buildjet for frontend either
@metabase-bot metabase-bot bot added .Team/QueryProcessor :hammer_and_wrench: visual Run Percy visual testing labels Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff 0633cd8...4af6112.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/LineAreaBarChart.module.css
frontend/src/metabase/visualizations/components/TableInteractive/TableInteractive.module.css
@kdoh frontend/src/metabase/ui/components/feedback/Alert/Alert.stories.mdx
frontend/src/metabase/ui/components/feedback/Alert/Alert.styled.tsx
frontend/src/metabase/ui/components/feedback/Alert/index.ts
frontend/src/metabase/ui/components/feedback/index.ts
frontend/src/metabase/ui/components/icons/Icon/Icon.tsx
frontend/src/metabase/ui/theme.ts
frontend/src/metabase/ui/utils/colors.ts
src/metabase/email/_header.mustache
src/metabase/email/legacy_no_self_service.mustache
src/metabase/email/messages.clj
@ranquild enterprise/frontend/src/metabase-enterprise/whitelabel/components/ImageUpload/ImageUpload.styled.tsx

Copy link

replay-io bot commented Apr 23, 2024

Status Complete ↗︎
Commit 4af6112
Results
2 Failed
⚠️ 6 Flaky
2418 Passed

@metamben metamben merged commit 1a7e986 into metrics-v2 Apr 23, 2024
108 of 111 checks passed
@metamben metamben deleted the merge-master-to-metrics-v2 branch April 23, 2024 19:42
ranquild added a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Team/QueryProcessor :hammer_and_wrench: visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet