[Epic] Highlight the selected data source in the notebook editor

[nemanjaglumac]

Links

• product doc
• feature branch: highlight-data-source
• issue links: N/A
• testing plan

Implementation Plan

This project is aiming to fix a family of the issues that all relate to the data picker experience. As such the natural sequencing and the progression would be to identify those issues first, and to work on them one by one. These are the dimensions we need to cover by the end of this project.

Dimensions

Beta Give feedback

1. Ad-hoc
2. Saved question (simple)
3. Saved question (nested)
4. Saved model (view + edit query definition)

Milestone 0

This phase includes going over the existing code, cleaning up and preparing it for the work needed in other milestones.

Cleanup and refactoring

Beta Give feedback

1. [HDS] Prep/cleanup steps for Highlighting the data source #39681
   .Team/QueryingComponents +1
   

Milestone 1

Models

Beta Give feedback

1. Cannot see Models as the data source in the data selector when opening a model #39699
   .Frontend .Team/QueryingComponents Priority:P2 Querying/Models Querying/Notebook Type:Bug +6
   

Milestone 2

Multi-schema

Beta Give feedback

1. Data source is not properly highlighted for simple saved questions based on a table in a multi-schema database #39807
   .Frontend .Team/QueryingComponents Priority:P2 Querying/Notebook Type:Bug +5
   

Milestone 3

The source collection

Beta Give feedback

1. Data source is not initially highlighted for nested questions and models once their source is moved to a different collection #39812
   .Frontend .Team/QueryingComponents Priority:P3 Querying/Notebook Type:Bug +5
   

Milestone 4

Tasks

Beta Give feedback

1. Data Selector opens with database field picker if no saved questions exist, but models exist #25142
   .Frontend .Reproduced Priority:P3 Querying/Models Querying/Notebook Type:Bug +6
   
2. E2E test coverage for "Highlight the selected data source in the notebook editor" project #40199
   .CI & Tests .Team/QueryingComponents backport support/Repro +4
   

---

Out of scope

Anything that requires significantly rewriting the data picker component is out of the scope of this project. There is a new entity picker that should replace the existing data picker, anyway. Everything that is thematically related will be listed below:

• Data picker shows "Saved Questions" on an empty *not yet activated* enterprise instance #40223
• When joining, the Raw Data selection shouldn't make me pick the database I'm using again #20406
• Edge cases:
  • What happens if the source question/model gets archived or deleted?
  • What happens if the source question gets turned into a model and vice versa?