E2E test coverage for "Highlight the selected data source in the notebook editor" project #40199
Conversation
nemanjaglumac
added
the
backport
|
nemanjaglumac
changed the title
| /** | ||
| * @type number | ||
| */ |
There was a problem hiding this comment.
Before we end up converting all helpers to TS, some of the monkey-patching will be needed because TS complains in TS specs.
| const modelDetails = { | ||
| name: "GUI Model", | ||
| query: { "source-table": REVIEWS_ID, limit: 1 }, | ||
| display: "table", | ||
| type: "model", | ||
| collection_id: SECOND_COLLECTION_ID, | ||
| }; |
There was a problem hiding this comment.
Only modelDetails.name is used later on.
There was a problem hiding this comment.
Ok?
I mostly extract this for readability.
There was a problem hiding this comment.
It looks like this object was meant to be passed to createQuestion but instead a different (identical) object is passed there - this duplication looks like a leftover.
There was a problem hiding this comment.
Oh, could be.
Will take a look at it. Thank you.
There was a problem hiding this comment.
I was stuck at a discrepancy between how the data picker works in OSS vs EE mode so I might have missed a few other details. Thanks again.
#40223
There was a problem hiding this comment.
Addressed this comment in d32bd0e
There was a problem hiding this comment.
IMO the best way out is to explicitly define the type of modelDetails, like this: const modelDetails: Parameters<typeof cy.createQuestion>[0] = {. No casting and we get a proper type check.
There was a problem hiding this comment.
Sounds good.
But my only concern is what happens if we ever decide to change the order in the future?
|
Stress-test after ff0d350 ✅ |
…book editor" project (#40199) * Add the initial test for the empty app db * Add reproduction for #25142 * Add test that covers only saved questions * Cover scenarios with a table as a source * Add tests that cover nested questions and models * Add test for simple model's source table * Remove intercepted schema routes * Improve assertion * Fix the test failing on enterprise instance * Add E2E reproduction for #40223 * Remove superfluous code block * Avoid casting
…book editor" project (#40199) (#40243) * Add the initial test for the empty app db * Add reproduction for #25142 * Add test that covers only saved questions * Cover scenarios with a table as a source * Add tests that cover nested questions and models * Add test for simple model's source table * Remove intercepted schema routes * Improve assertion * Fix the test failing on enterprise instance * Add E2E reproduction for #40223 * Remove superfluous code block * Avoid casting Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
This PR adds a test coverage for #39542
Closes #39542
Closes #39544
Closes #25142
Reproduces #25142
Reproduces #40223