Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Selector opens with database field picker if no saved questions exist, but models exist #25142

Closed
Tracked by #39542
gusaiani opened this issue Aug 31, 2022 · 2 comments · Fixed by #40199
Closed
Tracked by #39542

Data Selector opens with database field picker if no saved questions exist, but models exist #25142

gusaiani opened this issue Aug 31, 2022 · 2 comments · Fixed by #40199
Assignees
@nemanjaglumac
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Models aka Datasets Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects

Comments

@gusaiani
Copy link
Contributor

Describe the bug

image

To Reproduce

  1. Have no saved question in the system
  2. Save one or more model.
  3. +New › Question
  4. Data selector will open with the Sample Dataset field picker (if that's the data you use)

Expected behavior

Data selector should open with the option to choose between Raw Data or Models.
@gusaiani gusaiani added Type:Bug Product defects .Needs Triage labels Aug 31, 2022
@flamber flamber added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder Querying/Models aka Datasets .Frontend and removed .Needs Triage labels Aug 31, 2022
@flamber
Copy link
Contributor

flamber commented Aug 31, 2022

Related to #21511

@kulyk kulyk mentioned this issue Dec 12, 2022
Closed
27 tasks
@luizarakaki luizarakaki mentioned this issue Nov 9, 2023
Open
@nemanjaglumac nemanjaglumac mentioned this issue Mar 6, 2024
Closed
@nemanjaglumac
Copy link
Member

Not possible to reproduce anymore on master at d1c59da. We have a different issue right now. Even when there are no saved question, nor any saved models, the data selector always initializes as if there are saved questions.
image

Maybe because of the internal analytics?

@nemanjaglumac nemanjaglumac self-assigned this Mar 15, 2024
nemanjaglumac added a commit that referenced this issue Mar 15, 2024
@nemanjaglumac
Add reproduction for #25142
cd4e01d
@nemanjaglumac nemanjaglumac mentioned this issue Mar 15, 2024
Merged
kamilmielnik pushed a commit that referenced this issue Mar 18, 2024
@nemanjaglumac @kamilmielnik
Add reproduction for #25142
ac299d1
@replay-io replay-io bot mentioned this issue Mar 18, 2024
Closed
1 task
nemanjaglumac added a commit that referenced this issue Mar 18, 2024
@nemanjaglumac
E2E test coverage for "Highlight the selected data source in the note…
936e38a 
…book editor" project (#40199)

* Add the initial test for the empty app db

* Add reproduction for #25142

* Add test that covers only saved questions

* Cover scenarios with a table as a source

* Add tests that cover nested questions and models

* Add test for simple model's source table

* Remove intercepted schema routes

* Improve assertion

* Fix the test failing on enterprise instance

* Add E2E reproduction for #40223

* Remove superfluous code block

* Avoid casting
github-actions bot pushed a commit that referenced this issue Mar 18, 2024
@nemanjaglumac
E2E test coverage for "Highlight the selected data source in the note…
d578c02 
…book editor" project (#40199)

* Add the initial test for the empty app db

* Add reproduction for #25142

* Add test that covers only saved questions

* Cover scenarios with a table as a source

* Add tests that cover nested questions and models

* Add test for simple model's source table

* Remove intercepted schema routes

* Improve assertion

* Fix the test failing on enterprise instance

* Add E2E reproduction for #40223

* Remove superfluous code block

* Avoid casting
This was referenced Mar 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemanjaglumac nemanjaglumac

Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Models aka Datasets Querying/Notebook Items specific to the Custom/Notebook query builder .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Milestone
No milestone
3 participants
@gusaiani @flamber @nemanjaglumac