Custom field (formula) and custom expression forms are broken

[luxemate]

It's not possible to move cursor in Field Formula input as it instantly moves back to start position. It also doesn't offer me to choose an operation (+,- etc.), unlike Chrome in Windows does. In Chrome it's not even possible to blur from Field Formula input.

Warnings and errors in Chrome console:

• Your browser and the version: Chrome 58.0, Firefox 53.0
• Your operating system: Ubuntu Linux 16.04.2 LTS
• Your databases: Postgres
• Metabase version: 0.23.1
• Metabase hosting environment: JAR
• Metabase internal database: H2 (default)

[LukeAbell]

Same issue here. Chrome on OSX.

[mazameli]

Oh yikes, yeah. Here I've tried to write the word runs but the cursor moves back to the start after each key press, rendering the word backwards:

[mazameli]

Motion to add this to 0.24. It seems like a feature-breaking bug.

[VikramTiwari]

@mazameli I would argue that this is a hotfix that should go out as 0.23.2. Even if it's not a hotfix issue for the project, it's a bug that everyone will run into as their browsers get updated and a working release is breaking.

Also, confirming that this is not happening on Mac app.

[kdoh]

So after a bit of digging, it seems that in Chrome / FF the cursor position is always getting set to 0, 0 on every key press which is why things end up getting rendered backwards and the cursor can't ever leave the initial position.

I haven't been able to figure out exactly why that's happening specifically in those browsers and not in Safari (and therefore the mac app) yet though.

[tlrobinson]

I was able to reduce it down to this: https://jsfiddle.net/tlrobinson/wryfspsq/

When you have an empty input and enter a character, in Safari you get:

onSelectionChange 1
onSelectionChange 1
onSelectionChange 1

Whereas in Chrome 58 you get:

onSelectionChange 1
onSelectionChange 1
onSelectionChange 0
onSelectionChange 0
onSelectionChange 0
onSelectionChange 0

Haven't figured out anything beyond this yet.

[salsakran]

is this a bug in Chrome/FF or just a new behaviour? i.e. if we wait it out, will it get fixed on its own?

[tlrobinson]

Unclear because I'm not sure what the root cause is yet, but given it's happening in both FF and Chrome it seems like it's probably something we should fix.

[tlrobinson]

Also do we know if it ever worked on Firefox?

[VikramTiwari]

Not working on Firefox 49.0 not even on 53.0 (64-bit, Latest).

[tlrobinson]

@luxemate @LukeAbell @VikramTiwari I've got a fix for this in #4969, if you'd like to try it out.