Prompt for save when sharing unsaved question #10976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10447
Previously you had to save a question before seeing the share icon. Now the behavior matches alerts: You always see the icon. If you try to share an unsaved question, we prompt you to save first.
I moved the modal into QueryModals.jsx so it could live with the same logic for alerts. I ended up pulling the shared trigger that lived in
EmbedWidget
intoQuestionEmbedWidget
andDashboardEmbedWidget
since they now had separate triggering logic.