fix bug where column settings were dropped #11154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kdoh and/or @tlrobinson, mind giving this a review? |
tlrobinson
approved these changes
Oct 21, 2019
| @@ -145,7 +145,9 @@ export function applyChartTimeseriesXAxis( | |||
| const timestampFixed = moment(timestamp) | |||
| .utcOffset(dataOffset) | |||
| .format(); | |||
| const { column, columnSettings } = chart.settings.column(dimensionColumn); | |||
| const { column, ...columnSettings } = chart.settings.column( | |||
There was a problem hiding this comment.
Oh interesting, I though spreading undefined (which columnSettings would have been) would have crashed, but apparently you can spread null/undefined. I guess I can stop doing things like { ...(something || {}) }
There was a problem hiding this comment.
Yeah! I just had the same realization a few days ago!
mazameli
pushed a commit
that referenced
this pull request
Oct 21, 2019
* hide section picker if when viewing column settings * hide sidebar title * add ChartSettingsSidebar test * always show column settings title * lint * override sidebar title * remove unneeded diff * group reference sidebar tables by schema * keep everything as one list * use name instead of display_name * add tests * add schema pane * filter to querable tables * update tests * unused imports * sort schema and table names * change scalar compact formatting to depend on pixel width rather than grid width (#10932) * prompt for save when sharing unsaved question (#10976) * use generic props override instead of just `title` and `onBack` * Update pulse table style to match app (#10989) * undefined -> null, you can spread null aparently * Upgrade redshift driver to 1.2.36.1060 (#11181) * fix bug where column settings were dropped (#11154) * remove leading slash on publicPath (#11174) * Fix GA crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11113
I think this broke in #10864. I had forgotten a
...🤦♂. This PR adds the...and a test.