Use SearchResult component #14867
Merged
Use SearchResult component #14867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmacdonald
force-pushed
the
search-api-response-14832
branch
from
46824df
to
062940e
Compare
tsmacdonald
commented
Feb 18, 2021
| :name (if (or (= column :name) (nil? display_name)) name display_name) | ||
| :matched_column column | ||
| :matched_text match | ||
| :context (when-not (#{:name :display_name :collection_name} column) match-context) ;; TODO pull this out somewhere more responsible |
There was a problem hiding this comment.
these "magic" column names should live in search.config and both the when-not and if (L141) are a little jank, but I think the surrounding logic is going to change in the near future and don't want to waste cycles overoptimizing
tsmacdonald
force-pushed
the
search-api-response-14832
branch
2 times, most recently
from
5ad6b6c
to
b7a6a77
Compare
Codecov Report
@@ Coverage Diff @@
## master #14867 +/- ##
==========================================
- Coverage 83.93% 83.92% -0.01%
==========================================
Files 389 389
Lines 30485 30504 +19
Branches 2171 2171
==========================================
+ Hits 25587 25600 +13
- Misses 2727 2733 +6
Partials 2171 2171
Continue to review full report at Codecov.
|
Update the backend to return much richer match data [Fixes #14832]
tsmacdonald
force-pushed
the
search-api-response-14832
branch
from
b7a6a77
to
0d06433
Compare
kdoh
requested changes
Feb 22, 2021
There was a problem hiding this comment.
Looks like a few things are missing before this can go in and we can test further.
- We should use SearchResult on both the full search results page and in type ahead results.
- The
Our analyticscollection isn't showing up as the collection when something is saved there. I think that's due to the back end treating that collection strangely. - I think Metrics and Segments might not be accounted for yet which also tells me we need to improve our fallback case.
tsmacdonald
force-pushed
the
search-api-response-14832
branch
from
d4f23e7
to
4c8d878
Compare
kdoh
approved these changes
Feb 22, 2021
tsmacdonald
commented
Feb 22, 2021
tsmacdonald
force-pushed
the
search-api-response-14832
branch
from
4c8d878
to
49584f2
Compare
tsmacdonald
force-pushed
the
search-api-response-14832
branch
from
49584f2
to
5625858
Compare
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and update the backend to return much richer match data
[Fixes #14832]