Remove frontend search sorting #14898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmacdonald
force-pushed
the
remove-frontend-search-sorting
branch
2 times, most recently
from
61a1919
to
c7d23d5
Compare
Respect the sorting done by the backend
tsmacdonald
force-pushed
the
remove-frontend-search-sorting
branch
from
c7d23d5
to
91e5e76
Compare
daltojohnso
approved these changes
Feb 19, 2021
tsmacdonald
added a commit
that referenced
this pull request
Feb 22, 2021
* Use SearchResult component Update the backend to return much richer match data [Fixes #14832] * Increase the memoization cache for search scoring by common subseq (#14894) * Increase the memoization cache for search scoring by common subseq Also limit the size of input it can get (Hopefully) [Fixes #14852] * Don't group search results by type (#14898) Respect the sorting done by the backend * Format metrics and segments in search results; DRY up the code * Add normalizedCollection(); show "Our Analytics" collection in search results * Use SearchResult for typeahead results too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the order provided by the backend. Previously the BE would return things in a ~random order and the FE would group them by type, but we don't want that any more (soon we'll incorporate type into the BE scoring to get at the same problem)
The filtering by type in the sidebar still works as one would expect; that's why we still bother with
resultsByTypeat all