Fix subdimensions for a join table

[ariya]

This fixes #15446. To verify, run the Cypress test:

yarn test-cypress-no-build --spec frontend/test/metabase/scenarios/question/notebook.cy.spec.js

Steps to reproduce:

1. Ask a question, Custom question.
2. Sample Dataset, Orders table.
3. Join Data, People table.
4. Summarize, "Sum of Total"
5. Group by: "People - Users" and then "Created At".
6. Hover and then click on the "by month >"
7. The pop-up should show a list of binning choices.

Before:

There are duplicated entries in the pop-up. Note that the pop-up is too small (vertically), scroll around to check that in fact some entries (e.g. "Minute") appear twice.

After:

There is no more duplication in the pop-up.

[ariya]

Note that the Dimension logic has changed dramatically since PR #14897 (MBQL Refactor), i.e. there is no more specialized class such as JoinedDimension. Hopefully this PR does a sensible re-implementation of the logic.

[paulrosenzweig]

I don't understand exactly where the now filtered out dimensions were originating. I guess dimension_options? It seems like we might be able to construct the right list rather than filtering down at the end. That's a vague hypothesis though. I think shipping this is good!

[ariya]

I don't understand exactly where the now filtered out dimensions were originating. I guess dimension_options? It seems like we might be able to construct the right list rather than filtering down at the end. That's a vague hypothesis though. I think shipping this is good!

It is originated from the usual _dimensionForOption() function. But I think you raise a very good point here: I definitely should investigate the different of behavior of the said function, before and after MBQL field refactoring. Perhaps the underlying issue is the construction of the initial subdimensions (when taking into account a joined table).

[ariya]

Closing this, in favor of the updated approach in PR #15530.