Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15754 Repro: Can't use parentheses as expected in filter expressions #15758

Merged
merged 1 commit into from
Apr 22, 2021
Merged

#15754 Repro: Can't use parentheses as expected in filter expressions #15758

merged 1 commit into from
Apr 22, 2021

Conversation

nemanjaglumac
Copy link
Member

Status

PENDING REVIEW

What does this PR accomplish?

How to test this manually?

  • yarn test-cypress-open --spec frontend/test/metabase/scenarios/question/filter.cy.spec.js
  • Replace it.skip() with it.only() to run the test in isolation
  • The test should fail until the related issue is fixed

Additional notes:

  • Once the issue is fixed, please remove the .skip part (unskip the test completely)
  • Make sure the test is passing and
  • Merge it together with the fix

Screenshots:

image

@nemanjaglumac nemanjaglumac self-assigned this Apr 22, 2021
@nemanjaglumac nemanjaglumac added this to In progress in Cypress Testing via automation Apr 22, 2021
@nemanjaglumac nemanjaglumac moved this from In progress to Pending Review in Cypress Testing Apr 22, 2021
Base automatically changed from repro/issue_15748 to release-x.39.x April 22, 2021 19:28
@nemanjaglumac nemanjaglumac merged commit 43bf107 into release-x.39.x Apr 22, 2021
Cypress Testing automation moved this from Pending Review to Done and Merged (Cy Test) Apr 22, 2021
@nemanjaglumac nemanjaglumac deleted the repro/issue_15754 branch April 22, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamber flamber flamber approved these changes

@ariya ariya Awaiting requested review from ariya

Assignees

@nemanjaglumac nemanjaglumac

Labels
.CI & Tests support/Repro
Projects
Cypress Testing
Done and Merged (Cy Test)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nemanjaglumac @flamber