Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make TableInteractive cell more button-like #15833

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Conversation

daltojohnso
Copy link
Contributor

@daltojohnso daltojohnso commented Apr 27, 2021

This was annoying me--I kept accidentally triggering this cell because it used a mouseup event instead of a click. While I was tweaking that I noticed it wasn't keyboard accessible at all, so I went ahead a dropped a tabIndex + mousedown event on it.

before:
annoying

after:
onclick

keyboard accessible:
keyboard

Copy link
Contributor

@ariya ariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 🥇

Copy link
Member

@kulyk kulyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@daltojohnso daltojohnso merged commit ee82ff4 into master Apr 28, 2021
@daltojohnso daltojohnso deleted the dj-replace-onMouseUp branch April 28, 2021 16:31
@rlotun rlotun added this to the 0.40 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants