dimension list: hide sub-dimensions for fields that are FK #17783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawit-metabase
force-pushed
the
hide-sub-dimension-fk
branch
from
6d90609
to
e351b43
Compare
Codecov Report
@@ Coverage Diff @@
## master #17783 +/- ##
=======================================
Coverage 62.90% 62.90%
=======================================
Files 1630 1633 +3
Lines 66581 66608 +27
Branches 7304 7311 +7
=======================================
+ Hits 41882 41900 +18
- Misses 21510 21517 +7
- Partials 3189 3191 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Comment on lines
+79
to
+80
| .find(".Field-extra") | ||
| .should("not.have.descendants", "*"); |
There was a problem hiding this comment.
Oh, I like this very much! Elegant solution 👌
FWIW, we shouldn't even display the .Field-extra as an empty div, but that's out of the scope of this PR.
Great work, @pawit-metabase !
nemanjaglumac
approved these changes
Sep 7, 2021
camsaul
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely a regression from #14897 treating FK as sub-dimensions of the FK field (6bdd5e0#diff-7af510db40767873db52e7ebfd7cdeb5b4918d10ef08dfa2e998dab79fe66741R725) which DimensionList then later pick up to display.
Fixes #16787