Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FK fields shows sub-dimension selector #16787

Closed
flamber opened this issue Jun 27, 2021 · 0 comments · Fixed by #17783
Closed

FK fields shows sub-dimension selector #16787

flamber opened this issue Jun 27, 2021 · 0 comments · Fixed by #17783
Assignees
@pawit-metabase
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:UX
Milestone
0.41

Comments

@flamber
Copy link
Contributor

flamber commented Jun 27, 2021

Describe the bug
FK fields shows sub-dimension selector in Notebook dimension selector. Regression since 0.39.0

To Reproduce

  1. Custom question > Sample Dataset > Orders
  2. Summarize - hover a FK field and it will show a little sub-dimension selector
    image

Expected behavior
Don't show the sub-selector, since it's the same as the collapsed parts of the Select.
And we don't have any tests for these, so either remove the sub-select or add tests to prevent any problems.

Information about your Metabase Installation:
Tested 0.38.4 thru 0.39.4 and master c040f15 (2021-06-25). Regression since 0.39.0
@flamber flamber added Type:UX Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jun 27, 2021
@flamber flamber mentioned this issue Sep 4, 2021
Closed
@pawit-metabase pawit-metabase self-assigned this Sep 7, 2021
@pawit-metabase pawit-metabase mentioned this issue Sep 7, 2021
Merged
pawit-metabase added a commit that referenced this issue Sep 7, 2021
@pawit-metabase
dimension list: hide sub-dimensions for fields that are FK
e351b43 
Fixes #16787
pawit-metabase added a commit that referenced this issue Sep 8, 2021
@pawit-metabase
dimension list: hide sub-dimensions for fields that are FK (#17783)
2ffb8cb 
Fixes #16787
@flamber flamber added this to the 0.41 milestone Sep 8, 2021
@deploysentinel deploysentinel bot mentioned this issue Dec 8, 2022
Closed
@flamber flamber mentioned this issue Dec 22, 2022
Closed
@deploysentinel deploysentinel bot mentioned this issue Jan 23, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Jan 31, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Mar 28, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue Apr 20, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue May 12, 2023
Merged
@deploysentinel deploysentinel bot mentioned this issue May 31, 2023
Closed
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Feb 5, 2024
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
@replay-io replay-io bot mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawit-metabase pawit-metabase

Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:UX
Projects
None yet
Milestone
0.41
Development

Successfully merging a pull request may close this issue.

dimension list: hide sub-dimensions for fields that are FK metabase/metabase
2 participants
@flamber @pawit-metabase