Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18547 Repro: Wrong id used in links for questions added to dashboard in the activity page #18575

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

nemanjaglumac
Copy link
Member

Status

PENDING REVIEW

What does this PR accomplish?

How to test this manually?

  • yarn test-cypress-open
  • frontend/test/metabase/scenarios/onboarding/home/activity-page.cy.spec.js
  • Replace it.skip() with it.only() to run the test in isolation
  • The test should fail until the related issue is fixed

Additional notes:

  • Once the issue is fixed, please remove the .skip part (unskip the test completely)
  • Make sure the test is passing and
  • Merge it together with the fix

Screenshots:

image

@nemanjaglumac nemanjaglumac self-assigned this Oct 20, 2021
@nemanjaglumac nemanjaglumac added this to Pending Review in Cypress Testing via automation Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #18575 (158b1b1) into master (852e36f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18575   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files        1759     1759           
  Lines       68982    68982           
  Branches     7487     7487           
=======================================
  Hits        44225    44225           
  Misses      21453    21453           
  Partials     3304     3304           
Flag Coverage Δ
front-end 41.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852e36f...158b1b1. Read the comment docs.

@nemanjaglumac nemanjaglumac added the backport Automatically create PR on current release branch on merge label Oct 20, 2021
@nemanjaglumac nemanjaglumac merged commit 9c0ab06 into master Oct 20, 2021
Cypress Testing automation moved this from Pending Review to Done and Merged (Cy Test) Oct 20, 2021
@nemanjaglumac nemanjaglumac deleted the repro/issue_18547 branch October 20, 2021 18:38
github-actions bot pushed a commit that referenced this pull request Oct 20, 2021
nemanjaglumac added a commit that referenced this pull request Oct 20, 2021
… in the activity page (#18575) (#18576)

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .CI & Tests support/Repro
Projects
Cypress Testing
Done and Merged (Cy Test)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants