Activity entries for dashboard-add-cards events using incorrect card permalink

[lukeman]

Describe the bug
When cards are added to a dashboard, the activity entry in the frontend links to the wrong question ID. It's using the id of the report_dashboardcard instead of the card_id that was added to the dashboard.

To Reproduce
Steps to reproduce the behavior:

1. Add an existing card to a dashboard, observing the question's ID
2. Click through to Settings > Activity
3. Observe the link to the card you just added uses an incorrect ID (+ the correct slug for the question)

Expected behavior
Card name in the activity should link to the card as it does when the same card is created or edited.

Screenshots
Note the permalinks for the activity when I created the card and then the second when I added that card to a dashboard:

Activity log entry for the dashboard-add-cards event (both the join table id and the card_id are present):

Information about your Metabase Installation:

You can get this information by going to Admin -> Troubleshooting.

• Your browser and the version: Safari
• Your operating system: Mac
• Your databases: Postgres
• Metabase version: 0.41.0
• Metabase hosting environment: Self-hosted dockerfile + nomad
• Metabase internal database: Postgres

Severity
P3. Bug is limited to the activity log and mostly just confused me for a minute.

Additional context
I heart Metabase and all of y'all.

[flamber]

Regression since 0.40.0. Giving P2, since it makes the Activity Log much less useful, but could potentially link to the wrong questions, which could cause misunderstandings.

[nemanjaglumac]

If it helps, the logic behind this bumps the counter for every new added card, instead of respecting the card's id.

To reproduce:

• add a card to the dashboard - see that it has id 1
• add the same card to the dashboard again - now it has id 2