Add Basic Authentication to Druid

[nbotelhodev]

Objective

This PR allows using of basic header authentication only in Druid Database connection, files modified are exclusive of Druid code.

Feature

It's a simple adjustment, I added three fields in additional options UI and receive the values in Druid driver core to put in the basic header option of clj-http.

Tests

• My tests check if the basic header option is in clj-http request options or not.
• Run the frontend and Cypress end-to-end tests with yarn lint && yarn test)
• If there are changes to the backend codebase, run the backend tests with Clojure -X:dev:test
• Sign the Contributor License Agreement
  (unless it's a tiny documentation change).

---

This change is 

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (7557684) 70.80% compared to head (17c0a60) 70.78%.

❗ Current head 17c0a60 differs from pull request most recent head 203f5d3. Consider uploading reports for the commit 203f5d3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20412      +/-   ##
==========================================
- Coverage   70.80%   70.78%   -0.03%     
==========================================
  Files        2897     2893       -4     
  Lines      101037   100922     -115     
  Branches    12672    12653      -19     
==========================================
- Hits        71542    71435     -107     
+ Misses      24038    24037       -1     
+ Partials     5457     5450       -7     

Flag	Coverage Δ
back-end	86.60% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 68 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[camsaul]

Cool, this LGTM.

I had to approve this to run on CI so when that's done we can merge. Some of the jobs should fail since we don't inject credentials into third-party PRs but we can still merge anyway if Druid tests and linters pass

[gpodevijn]

Thanks again for the work, it'll be very useful for us.
Is there any chance that this PR will be merged in the next release?

[gpodevijn]

I just realised that the token's box is not a "password" box which makes the token visible from the UI (and probably not encrypted in the DB).

We're using Imply's Druid API pass as the token value to be able to connect to Druid. Would it be possible to hide and encrypt the token value?

Thank you!

[flamber]

@gpodevijn Encryption is handled for everything in metabase_database.details https://www.metabase.com/docs/latest/operations-guide/encrypting-database-details-at-rest.html

And change type: string to type: password or type: secret, that should automatically prevent it from being included in responses.

[camsaul]

• Fix merge conflicts
• Fix plaintext passwords

Then request another review 💪

[Ray33]

@flamber @camsaul Can you please update about the status of this PR ?

[flamber]

@Ray33 It's written right above your comment.

[Ray33]

@flamber Changes were done . Please check.

[flamber]

@Ray33 And @nbotelhodev has already requested a review from Cam a few hours ago, so you'll have to wait until there's a review.

[nbotelhodev]

Could you help me to merge this PR, please?

[Ray33]

Could you help to merge this PR, please?

[nbotelhodev]

Hey guys @gpodevijn @flamber
Help me merge this MR, please!

[Ray33]

@flamber can you please help with merge and rollout ?

out of date

[camsaul]

@metabase/core-backend-qp let's see if we can get this over the line for the next cycle

[carstenkadmos]

having this would help us a great deal as well! Thanks

[metamben]

LGTM