-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs - frontmatter #23272
docs - frontmatter #23272
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23272 +/- ##
==========================================
- Coverage 64.10% 64.08% -0.03%
==========================================
Files 2582 2620 +38
Lines 82241 82427 +186
Branches 10162 10169 +7
==========================================
+ Hits 52723 52822 +99
- Misses 25344 25426 +82
- Partials 4174 4179 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds frontmatter with title key to doc pages.
Additionally, it updates
src/metabase/cmd/endpoint-dox.clj
script to generate frontmatter for API doc pages.This is step one in improving our doc search results' title formatting, as well as other places where we use the de-slugged URL in place of an actual page title on our website.