Fetch static viz code changes while running in the dev mode #26015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 64.20% // Head: 64.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #26015 +/- ##
=======================================
Coverage 64.20% 64.20%
=======================================
Files 3087 3087
Lines 91104 91104
Branches 11472 11472
=======================================
Hits 58494 58494
Misses 28020 28020
Partials 4590 4590
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alxnddr
force-pushed
the
add-static-viz-build-watch-command
branch
from
f982e2d
to
0d4b171
Compare
…om/metabase/metabase into add-static-viz-build-watch-command
ranquild
reviewed
Oct 20, 2022
webpack.static-viz.config.js
Outdated
| @@ -47,4 +49,7 @@ module.exports = { | |||
| "metabase-lib": LIB_SRC_PATH, | |||
| }, | |||
| }, | |||
| optimization: { | |||
| minimize: !shouldDisableMinimization | |||
There was a problem hiding this comment.
@alxnddr you could use env.WEBPACK_WATCH to disable minification in that case https://webpack.js.org/api/cli/#environment-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FE engineers mostly use
yarn devto run everything orclojure -M:runto run the backend separately locally for development. When working on static viz in order to test updated code engineers needed to rebuild the static viz bundle and then rerun their backend which is not great from the developer experience perspective. This PR adds theyarn build-static-viz:watchcommand to watch for static viz files changes and update the bundle. Also, it runs as a part ofyarn dev.I'm not using webpack
--mode=developmentbecause it still minimizes the code. And I'm not using--mode=nonewhich does not minimize the code but it creates a bundle with globals such asprocesswhich does not exist in the static viz execution environment.How to verify
yarn devfrontend/src/metabase/static-viz/components/ProgressBar/utils.tsand change any text that was visible in the test emailDemo
static-viz-update-without-restarting.mov