Fix form reinitialization with formik #26292
Conversation
This reverts commit cb88b24.
Codecov ReportBase: 64.28% // Head: 64.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #26292 +/- ##
==========================================
+ Coverage 64.28% 64.30% +0.01%
==========================================
Files 3148 3148
Lines 92202 92204 +2
Branches 11699 11699
==========================================
+ Hits 59270 59289 +19
+ Misses 28242 28219 -23
- Partials 4690 4696 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ranquild
added
the
backport
|
|
||
| const useFormErrorMessage = (): string | undefined => { | ||
| const { values, errors } = useFormikContext(); | ||
| const { status, message } = useFormState(); | ||
| const { status, message } = useContext(FormContext); |
There was a problem hiding this comment.
Should we maybe add another hook like useForm that'd basically return useContext(FormContext);? So there's no need to carry over the context here and there all the time
There was a problem hiding this comment.
Fixed - added a hook called useFormContext. Decided to use the same naming convention the formik does, i.e. useFormikContext
| setState({ status: "pending" }); | ||
| await onSubmit(data, helpers); | ||
| helpers.setStatus({ status: "fulfilled" }); | ||
| setState({ status: "fulfilled" }); |
There was a problem hiding this comment.
My first thought was "why is setState called without this?" 😄
Epic #26178
Currently the submit button doesn't show
Successmessage whenenableReinitializeis passed toFormik. This happens becauseFormikresets the internalstatusfield used for submit status tracking. This PR fixes the issue by moving the submit state to its own context.How to test:
UpdateSuccessand becomes disabled after submit