Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 backported "Fix form reinitialization with formik" #26370

Merged

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Nov 10, 2022

@metabase-bot metabase-bot bot enabled auto-merge (squash) November 10, 2022 13:38
@github-actions
Copy link

Notifying subscribers in CODENOTIFY files for diff f3a0cb2...e26c310.

Notify File(s)
@ranquild frontend/src/metabase/account/profile/components/UserProfileForm/UserProfileForm.unit.spec.tsx

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 64.26% // Head: 64.29% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (e26c310) compared to base (f3a0cb2).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-x.45.x   #26370      +/-   ##
==================================================
+ Coverage           64.26%   64.29%   +0.02%     
==================================================
  Files                3146     3147       +1     
  Lines               92143    92143              
  Branches            11690    11689       -1     
==================================================
+ Hits                59220    59239      +19     
+ Misses              28244    28220      -24     
- Partials             4679     4684       +5     
Flag Coverage Δ
front-end 45.18% <90.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/components/FormSubmitButton/FormSubmitButton.tsx 80.00% <ø> (ø)
...base/core/hooks/use-form-submit/use-form-submit.ts 68.75% <75.00%> (+2.08%) ⬆️
...base/core/components/FormProvider/FormProvider.tsx 100.00% <100.00%> (ø)
.../metabase/core/context/FormContext/FormContext.tsx 100.00% <100.00%> (ø)
...se/core/hooks/use-form-context/use-form-context.ts 100.00% <100.00%> (ø)
...s/use-form-error-message/use-form-error-message.ts 66.66% <100.00%> (ø)
...s/use-form-submit-button/use-form-submit-button.ts 95.00% <100.00%> (ø)
...ile/components/UserProfileForm/UserProfileForm.tsx 73.07% <0.00%> (+73.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@metabase-bot metabase-bot bot merged commit 017f3f0 into release-x.45.x Nov 10, 2022
@metabase-bot metabase-bot bot deleted the backport-5cba39abcf9d346343782f6007e51eb7f48c128a branch November 10, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant