Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Remove support for Heroku deployment (#25124) #26298

Conversation

nemanjaglumac
Copy link
Member

Manual backport of #25124

@nemanjaglumac nemanjaglumac requested a review from a team November 8, 2022 19:15
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 64.25% // Head: 64.25% // No change to project coverage 👍

Coverage data is based on head (d4511b2) compared to base (77602cc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-x.45.x   #26298   +/-   ##
===============================================
  Coverage           64.25%   64.25%           
===============================================
  Files                3146     3146           
  Lines               92105    92105           
  Branches            11687    11688    +1     
===============================================
  Hits                59181    59181           
+ Misses              28246    28245    -1     
- Partials             4678     4679    +1     
Flag Coverage Δ
back-end 85.55% <ø> (ø)
front-end 45.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/metabase/models/query.clj 92.30% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nemanjaglumac nemanjaglumac merged commit b7bb6ae into release-x.45.x Nov 9, 2022
@nemanjaglumac nemanjaglumac deleted the backport-1f897ac0aaa382a522fc954002336985d87c00db branch November 9, 2022 04:38
nemanjaglumac added a commit that referenced this pull request Dec 6, 2022
nemanjaglumac added a commit that referenced this pull request Dec 6, 2022
This reverts commit b7bb6ae.

* Update docs/installation-and-operation/running-metabase-on-heroku.md

Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants