Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuestionRunningTime to QueryBuilder footer #29486

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simivar
Copy link

@simivar simivar commented Mar 23, 2023

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes #29482

Description

Shows "Running time" in the bottom right corner

How to verify

  1. New question -> SQL Query -> bottom right corner

Checklist

  • Tests have been added/updated to cover changes in this PR

This change is Reviewable

@paoliniluis
Copy link
Contributor

Hi @simivar thanks for your contribution. In order for this PR to be ready to review, we'll need you to sign the CLA and also add tests to cover this new feature

@simivar
Copy link
Author

simivar commented Mar 24, 2023

@paoliniluis I can easily add tests for the formatting function, but since I am not a frontend dev question from me: is there a test for the View part? Is footer tested anywhere? Some Selenium or something?

@paoliniluis
Copy link
Contributor

Check the developer documentation

@simivar
Copy link
Author

simivar commented Mar 26, 2023

I've added tests for fullDuration function

@paoliniluis paoliniluis linked an issue Mar 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show query running time on UI Feature request: Query response time
2 participants