Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] fk-filter drills should not appear on native queries #36660

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

bshepherdson
Copy link
Contributor

They were added incorrectly in fixing #35689.

Fixes #36633.

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@metabase-bot metabase-bot bot added the .Team/QueryProcessor(deprecated) Use .Team/Querying instead label Dec 11, 2023
@bshepherdson bshepherdson requested a review from a team December 11, 2023 20:17
@bshepherdson bshepherdson added the no-backport Do not backport this PR to any branch label Dec 11, 2023
They were added incorrectly in fixing #35689.

Fixes #36633.
@bshepherdson bshepherdson force-pushed the mblib-drills-fk-filter-only-on-mbql branch from 4925862 to 54d555b Compare December 11, 2023 20:33
@bshepherdson bshepherdson enabled auto-merge (squash) December 11, 2023 20:53
@bshepherdson bshepherdson merged commit 5e873d1 into master Dec 11, 2023
104 checks passed
@bshepherdson bshepherdson deleted the mblib-drills-fk-filter-only-on-mbql branch December 11, 2023 21:02
Copy link
Contributor

@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@bshepherdson bshepherdson added this to the 0.49 milestone Dec 11, 2023
qnkhuat pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor(deprecated) Use .Team/Querying instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MLv2] [BE] [Bug] fk-filter should not be returned for native queries
2 participants