Sync index info: sqlserver and sqlite #36665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
calherries
reviewed
Dec 12, 2023
|
Looks like there's a few sqlite tests failing, I'm not sure why though because they seem unrelated. |
1 flaky test on run #188 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| scenarios > question > native subquery > should be able to reference a saved native question that ends with a semicolon `;` (metabase#28218) |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #36665 ↗︎
calherries
reviewed
Dec 14, 2023
| ;; In sqlite a PK will implicitly have a UNIQUE INDEX, but if the PK is integer the getIndexInfo method from | ||
| ;; jdbc doesn't return it as indexed. so we need to manually get mark the pk as indexed here | ||
| (cond-> ((get-method driver/describe-table-indexes :sql-jdbc) driver database table) | ||
| (string? pk) |
There was a problem hiding this comment.
Why string?? What other type could pk be?
Suggested change
| (string? pk) | |
| (string? pk) |
There was a problem hiding this comment.
Then ideally you should use some? instead for readability. When I read this, I was questioning why such a specific check was made, and wondering whether the pk could be something other than a string, and then wondering why we would only add pks that were strings and not other types. It doesn't help that get-table-pks's docstring doesn't mention the return type.
calherries
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone 3 of #36452
These 2 drivers are JDBC drivers so it already works, this PR is mostly about making the tests work properly
After this we should be done syncing index info for all the drivers that support it