Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] Cache JS -> CLJS metadata conversion #38375

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[MLv2] Cache JS -> CLJS metadata conversion #38375

merged 1 commit into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. [MLv2] Cache JS -> CLJS metadata conversion 

    This previous got rebuilt from scratch over and over, since different
queries being handed the same JS `Metadata` instance were returning
completely separate `MetadataProvider`s.

The FE replaces the `Metadata` instance as new metadata arrives from the
BE, so the `metabase.lib.cache/side-channel-cache` which is attached to
the input object is implicitly invalidated when the old `Metadata` is
thrown away.
    @bshepherdson
    bshepherdson committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ceb9bf9 View commit details
    Browse the repository at this point in the history