New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLv2] Cache JS -> CLJS metadata conversion #38375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
metamben
approved these changes
Feb 1, 2024
This previous got rebuilt from scratch over and over, since different queries being handed the same JS `Metadata` instance were returning completely separate `MetadataProvider`s. The FE replaces the `Metadata` instance as new metadata arrives from the BE, so the `metabase.lib.cache/side-channel-cache` which is attached to the input object is implicitly invalidated when the old `Metadata` is thrown away.
bshepherdson
force-pushed
the
mblib-cache-metadata-conversion
branch
from
February 1, 2024 20:28
1df6953
to
ceb9bf9
Compare
@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
npfitz
pushed a commit
that referenced
this pull request
Feb 5, 2024
This previous got rebuilt from scratch over and over, since different queries being handed the same JS `Metadata` instance were returning completely separate `MetadataProvider`s. The FE replaces the `Metadata` instance as new metadata arrives from the BE, so the `metabase.lib.cache/side-channel-cache` which is attached to the input object is implicitly invalidated when the old `Metadata` is thrown away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previous got rebuilt from scratch over and over, since different
queries being handed the same JS
Metadata
instance were returningcompletely separate
MetadataProvider
s.The FE replaces the
Metadata
instance as new metadata arrives from theBE, so the
metabase.lib.cache/side-channel-cache
which is attached tothe input object is implicitly invalidated when the old
Metadata
isthrown away.