Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLv2] Cache JS -> CLJS metadata conversion #38375

Merged
merged 1 commit into from Feb 1, 2024

Conversation

bshepherdson
Copy link
Contributor

This previous got rebuilt from scratch over and over, since different
queries being handed the same JS Metadata instance were returning
completely separate MetadataProviders.

The FE replaces the Metadata instance as new metadata arrives from the
BE, so the metabase.lib.cache/side-channel-cache which is attached to
the input object is implicitly invalidated when the old Metadata is
thrown away.

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Feb 1, 2024
@bshepherdson bshepherdson added the no-backport Do not backport this PR to any branch label Feb 1, 2024
Copy link

replay-io bot commented Feb 1, 2024

StatusComplete ↗︎
Commitceb9bf9
Results
⚠️ 2 Flaky
2263 Passed

src/metabase/lib/cache.cljc Outdated Show resolved Hide resolved
This previous got rebuilt from scratch over and over, since different
queries being handed the same JS `Metadata` instance were returning
completely separate `MetadataProvider`s.

The FE replaces the `Metadata` instance as new metadata arrives from the
BE, so the `metabase.lib.cache/side-channel-cache` which is attached to
the input object is implicitly invalidated when the old `Metadata` is
thrown away.
@bshepherdson bshepherdson force-pushed the mblib-cache-metadata-conversion branch from 1df6953 to ceb9bf9 Compare February 1, 2024 20:28
@bshepherdson bshepherdson enabled auto-merge (squash) February 1, 2024 20:29
@bshepherdson bshepherdson merged commit 2d6d12c into master Feb 1, 2024
107 checks passed
@bshepherdson bshepherdson deleted the mblib-cache-metadata-conversion branch February 1, 2024 21:03
Copy link

github-actions bot commented Feb 1, 2024

@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@bshepherdson bshepherdson added this to the 0.49 milestone Feb 1, 2024
npfitz pushed a commit that referenced this pull request Feb 5, 2024
This previous got rebuilt from scratch over and over, since different
queries being handed the same JS `Metadata` instance were returning
completely separate `MetadataProvider`s.

The FE replaces the `Metadata` instance as new metadata arrives from the
BE, so the `metabase.lib.cache/side-channel-cache` which is attached to
the input object is implicitly invalidated when the old `Metadata` is
thrown away.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants