Extend param substitution to handle datetimes #38695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this only dates were supported as values for native timestamp field parameters.
|
metamben
approved these changes
Feb 13, 2024
| @@ -93,7 +93,7 @@ | |||
| (mt/with-clock #t "2018-07-01T12:30:00.000Z" | |||
| (mt/with-metadata-provider meta/metadata-provider | |||
| (let [field-filter (params/map->FieldFilter | |||
| {:field (lib.metadata/field (qp.store/metadata-provider) (meta/id :checkins :date)) | |||
| {:field (lib.metadata/field (qp.store/metadata-provider) (meta/id :orders :created-at)) | |||
There was a problem hiding this comment.
It's unexpected for me that the rest of the test doesn't need changing. Where does/should "PUBLIC"."CHECKINS" come from?
snoe
added
the
backport
|
@snoe Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Extend param substitution to handle datetimes Prior to this only dates were supported as values for native timestamp field parameters. * Check for exclusion filter when determining alignment unit
metabase-bot bot
added a commit
that referenced
this pull request
Feb 15, 2024
* Extend param substitution to handle datetimes Prior to this only dates were supported as values for native timestamp field parameters. * Check for exclusion filter when determining alignment unit Co-authored-by: Case Nelson <case@metabase.com>
|
@metabase-bot backport release-x.48.x |
|
@snoe I'm backporting to 48 because it looks like this never hit the 48 branch. |
|
@calherries something went wrong while creating a backport [Logs] |
calherries
added a commit
that referenced
this pull request
Feb 22, 2024
* Extend param substitution to handle datetimes Prior to this only dates were supported as values for native timestamp field parameters. * Check for exclusion filter when determining alignment unit Co-authored-by: Case Nelson <case@metabase.com>
calherries
added a commit
that referenced
this pull request
Feb 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38037
Fixes #33492
Prior to this only dates were supported as values for native timestamp field parameters. By properly aligning the temporal unit, we can ensure that native filters match gui filters.