Backport Extend param substitution to handle datetimes to 48 (#38695) #39062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend param substitution to handle datetimes Prior to this only dates were supported as values for native timestamp field parameters. * Check for exclusion filter when determining alignment unit Co-authored-by: Case Nelson <case@metabase.com>
|
snoe
approved these changes
Feb 22, 2024
|
@snoe I wondered about that. I'm not sure what to do when backporting driver changes, because we only have a section for the 48.0 release. This is just a warning that we're deprecating the multimethod so I think it's fine to leave in the 49 release and omit it here? |
|
Looks like there are more failures |
|
Looks like the entry needs to be made in the changelog for the tests to pass. I'll add it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually backports: #38695
Also cherry-picks #37813 which is a necessary prerequisite for the fix.
I manually tested this fixes #38037 using the repro steps here #38037 (comment)