Replace lodash.clonedeep with structuredClone in FE #38971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e94ea96...6ff6a70.
|
|
uladzimirdev
force-pushed
the
use-structured-clone
branch
from
6ff6a70
to
2f57b90
Compare
oleggromov
reviewed
Feb 22, 2024
| constructor(...args) { | ||
| super(...args); | ||
| // https://github.com/jsdom/jsdom/issues/3363 | ||
| this.global.structuredClone = cloneDeep; |
There was a problem hiding this comment.
I am not sure how relevant/working this is, but here's a suggestion to use Node's structuredClone.
jsdom/jsdom#3363 (comment)
There was a problem hiding this comment.
long story short - it broke a check that clojure uses under the hood: structuredClone(array) instanceof Array returned false
|
will be replaced with #39032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
If you are merging into master, please add either a
backportor ano-backportlabel to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details.Closes https://github.com/metabase/metabase/issues/[issue_number]
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist