[MLv2] Handle Object.isFrozen() legacy columns as input
#39032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cljs.core/hash` mutates vanilla JS arrays to attach a UID to them for hashing purposes. Before this change, given a `DatasetColumn` with a frozen `field_ref` array, we would use it directly on the `:metadata/column`, and `(hash column)` would try to mutate the frozen array and throw. This clones the array while converting the legacy column to MLv2 form, so there's no issue with mutating it. Fixes the `closure_uid_123456789` issue.
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
bshepherdson
added
the
backport
ranquild
approved these changes
Feb 21, 2024
1 task
metamben
approved these changes
Feb 22, 2024
bshepherdson
added a commit
that referenced
this pull request
Mar 26, 2024
…39032)" Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
bshepherdson
added a commit
that referenced
this pull request
Mar 26, 2024
…39032)" Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
bshepherdson
added a commit
that referenced
this pull request
Mar 26, 2024
…39032)" Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cljs.core/hashmutates vanilla JS arrays to attach a UID to them forhashing purposes. Before this change, given a
DatasetColumnwith afrozen
field_refarray, we would use it directly on the:metadata/column, and(hash column)would try to mutate the frozenarray and throw.
This clones the array while converting the legacy column to MLv2 form,
so there's no issue with mutating it.
Fixes the
closure_uid_123456789issue.