-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required filters: track when a filter is made required #39159
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
snowplow/iglu-client-embedded/schemas/com.metabase/dashboard/jsonschema/1-1-4
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| { | ||
| "$schema": "http://iglucentral.com/schemas/com.snowplowanalytics.self-desc/schema/jsonschema/1-0-0#", | ||
| "description": "Dashboard events", | ||
| "self": { | ||
| "vendor": "com.metabase", | ||
| "name": "dashboard", | ||
| "format": "jsonschema", | ||
| "version": "1-1-4" | ||
| }, | ||
| "type": "object", | ||
| "properties": { | ||
| "event": { | ||
| "description": "Event name", | ||
| "type": "string", | ||
| "enum": [ | ||
| "dashboard_created", | ||
| "dashboard_saved", | ||
| "question_added_to_dashboard", | ||
| "auto_apply_filters_disabled", | ||
| "dashboard_tab_created", | ||
| "dashboard_tab_deleted", | ||
| "dashboard_tab_duplicated", | ||
| "new_text_card_created", | ||
| "new_heading_card_created", | ||
| "new_link_card_created", | ||
| "new_action_card_created", | ||
| "card_set_to_hide_when_no_results", | ||
| "dashboard_pdf_exported", | ||
| "card_moved_to_tab", | ||
| "dashboard_card_duplicated", | ||
| "dashboard_card_replaced", | ||
| "dashboard_section_added", | ||
| "dashboard_width_toggled", | ||
| "dashboard_filter_required" | ||
| ], | ||
| "maxLength": 1024 | ||
| }, | ||
| "dashboard_id": { | ||
| "description": "Unique identifier for a dashboard within the Metabase instance", | ||
| "type": "integer", | ||
| "minimum": 0, | ||
| "maximum": 2147483647 | ||
| }, | ||
| "question_id": { | ||
| "description": "Unique identifier for a question added to a dashboard", | ||
| "type": [ | ||
| "integer", | ||
| "null" | ||
| ], | ||
| "minimum": 0, | ||
| "maximum": 2147483647 | ||
| }, | ||
| "num_tabs": { | ||
| "description": "Number of tabs affected after the event", | ||
| "type": [ | ||
| "integer", | ||
| "null" | ||
| ], | ||
| "minimum": 0, | ||
| "maximum": 2147483647 | ||
| }, | ||
| "total_num_tabs": { | ||
| "description": "Total number of active tabs after the events", | ||
| "type": [ | ||
| "integer", | ||
| "null" | ||
| ], | ||
| "minimum": 0, | ||
| "maximum": 2147483647 | ||
| }, | ||
| "duration_milliseconds": { | ||
| "description": "Duration the action took to complete in milliseconds", | ||
| "type": [ | ||
| "integer", | ||
| "null" | ||
| ], | ||
| "minimum": 0, | ||
| "maximum": 2147483647 | ||
| }, | ||
| "section_layout": { | ||
| "description": "String describing the layout that was selected from the pre-built options", | ||
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], | ||
| "maxLength": 1024 | ||
| }, | ||
| "full_width": { | ||
| "description": "Boolean set to True if the dashboard was toggled to full width and False if full width was disabled.", | ||
| "type": [ | ||
| "boolean", | ||
| "null" | ||
| ] | ||
| } | ||
| }, | ||
| "required": [ | ||
| "event", | ||
| "dashboard_id" | ||
| ], | ||
| "additionalProperties": true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we track only when parameter becomes required from a not-required state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the case when
requiredistrueandparamater.requiredis also true?We don't emit this action like that but I could add an additional check if you think it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually mean (if I understand the logic correctly) that we need to track when parameter wasn't required and then became required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I understood. In case we were emitting this action without checks (now because it's a "switch" you can't emit it when a parameter is already required), it would make sense. But broadly speaking, I don't think this is necessary.
This event is used to track feature adoption, which Conor agreed doesn't have to be very precise. That's why we didn't track it at saving for instance and instead track just toggling it on.