Required filters: track when a filter is made required #39159
Conversation
|
oleggromov
changed the title
oleggromov
changed the title
| @@ -298,6 +301,13 @@ export const setParameterRequired = createThunkAction( | |||
| required, | |||
| })); | |||
| } | |||
|
|
|||
| if (required) { | |||
There was a problem hiding this comment.
shouldn't we track only when parameter becomes required from a not-required state?
There was a problem hiding this comment.
Do you mean the case when required is true and paramater.required is also true?
We don't emit this action like that but I could add an additional check if you think it makes sense.
There was a problem hiding this comment.
I actually mean (if I understand the logic correctly) that we need to track when parameter wasn't required and then became required
There was a problem hiding this comment.
Yeah, I understood. In case we were emitting this action without checks (now because it's a "switch" you can't emit it when a parameter is already required), it would make sense. But broadly speaking, I don't think this is necessary.
This event is used to track feature adoption, which Conor agreed doesn't have to be very precise. That's why we didn't track it at saving for instance and instead track just toggling it on.
There was a problem hiding this comment.
I think we need to update some test (probably e2e like it's done here) to be sure events are logged
|
@oleggromov Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
oleggromov
added
backport
Adds the
dashboard_filter_requiredevent and updates schemas. Closes #39066What exactly is tracked
Every time the toggle is flipped to required, we will log an event.
Confirmed by Conor on Slack.
Testing
Tracking works locally with a setup described here.