Disable saving models without up-to-date result_metadata #40087
Conversation
ranquild
added
the
backport
ranquild
changed the title
|
ranquild
changed the title
| @@ -82,13 +81,6 @@ const Tables = createEntity({ | |||
| // loads `query_metadata` for a single table | |||
| fetchMetadata: compose( | |||
| withAction(FETCH_METADATA), | |||
| withForceReload((state, { id }) => { | |||
There was a problem hiding this comment.
This hack is no longer needed. Introduced here #39311
| ButtonsS.ButtonSmall, | ||
| )} | ||
| />, | ||
| saveButtonTooltipLabel ? ( |
There was a problem hiding this comment.
Instead of conditionally rendering the Tooltip we could pass disabled={!saveButtonTooltipLabel} prop to it.
This way we could inline the ActionButton back here and remove key prop from it.
There was a problem hiding this comment.
Didn't know about about disabled, thanks!
| fields.every(field => field.display_name); | ||
|
|
||
| const saveButtonTooltipLabel = | ||
| !isEmpty && isDirty && isNative && isResultDirty |
There was a problem hiding this comment.
Why only native models?
There was a problem hiding this comment.
Because for MBQL queries result_metadata can be computed by the BE without running the query
| disabled={!saveButtonTooltipLabel} | ||
| > | ||
| <ActionButton | ||
| key="save" |
There was a problem hiding this comment.
Redundant now
| key="save" |
|
@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Fixes #37009
Disables creating new and updating existing models without
result_metadata. That means that if the query was changed, the user would have to run the query first and wait for results.How to verify: