New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated native models may lose their result set metadata #37009
Labels
.Backend
.Escalation
.Frontend
Priority:P2
Average run of the mill bug
Querying/Nested Queries
Questions based on other saved questions
Querying/
Type:Bug
Product defects
Milestone
Comments
zbodi74
added
Type:Bug
Product defects
Querying/Nested Queries
Questions based on other saved questions
.Needs Triage
Querying/
labels
Dec 20, 2023
zbodi74
changed the title
Updated native models may lose their result set metadata and dependent queries may break
Updated native models may lose their result set metadata
Dec 20, 2023
paoliniluis
added
Priority:P2
Average run of the mill bug
and removed
.Needs Triage
labels
Dec 21, 2023
metamben
added a commit
that referenced
this issue
Feb 26, 2024
metamben
added a commit
that referenced
this issue
Feb 27, 2024
kamilmielnik
added a commit
that referenced
this issue
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
added a commit
that referenced
this issue
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
added a commit
that referenced
this issue
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Tamás Benkő <tamas@metabase.com>
kamilmielnik
added a commit
that referenced
this issue
Feb 28, 2024
* Keep result-metadata of native queries if possible Part of #37009. * Fix typo * Add a fallback for when resultMetadata is not available * Revert "Add a fallback for when resultMetadata is not available" This reverts commit 5ad3a8b. * Move resultsMetadata logic into getSubmittableQuestion * Add a fallback for when resultMetadata is not available * Add explanatory comment * Guard against missing resultsMetadata * Add repro for #35039 * Simplify the test * Add an explanatory comment * Fix test * Rename promise to runQuestionPromise --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by: Tamás Benkő <tamas@metabase.com>
Reopening. Fix will be reverted. See Slack discussion. |
This was referenced Feb 29, 2024
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Backend
.Escalation
.Frontend
Priority:P2
Average run of the mill bug
Querying/Nested Queries
Questions based on other saved questions
Querying/
Type:Bug
Product defects
Describe the bug
Upon updating a native model which is based on another model, the result set metadata may be lost.
When this occurs, the query editor won't show available columns for questions that are based on this model.
The workaround is to update the model, and making sure to preview the results before saving it.
To Reproduce
model1
:model2
, which usesmodel1
as its source:, and save it, without previewing the results in the editor.
model2
.Expected behavior
It should wirk
Logs
Logs:
/api/card response for
model2
:Severity
Found this while troubleshooting for a customer. A simple workaround exists.
Additional context
No response
The text was updated successfully, but these errors were encountered: