Fix multi-schema data selector header styling #40101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes spacing equal on both sides of the divider - Changes the divider from the hyphen to the forward slash
nemanjaglumac
added
the
backport
|
mazameli
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Nit/question: in your screenshots the words "Multi-schema" and "Schema two" look slightly like different colors. Are my eyes deceiving me?
But as for the actual issue being addressed in this PR: I love your attention to detail, and I'm cool with the change here.
They are not. |
|
@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
* Fix multi-schema data selector header styling - Makes spacing equal on both sides of the divider - Changes the divider from the hyphen to the forward slash * Change the breadcrumb divider in the Table Metadata section
metabase-bot bot
added a commit
that referenced
this pull request
Mar 15, 2024
* Fix multi-schema data selector header styling - Makes spacing equal on both sides of the divider - Changes the divider from the hyphen to the forward slash * Change the breadcrumb divider in the Table Metadata section Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Fixes #39999