Remove Models from Browse data #40108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
added
the
backport
|
|
Looks good! 👍 |
iethree
approved these changes
Mar 13, 2024
iethree
pushed a commit
that referenced
this pull request
Mar 14, 2024
# Conflicts: # frontend/src/metabase/browse/analytics.ts # frontend/src/metabase/browse/components/BrowseApp.tsx # frontend/src/metabase/browse/components/ModelExplanationBanner.tsx # frontend/src/metabase/routes.jsx
rafpaf
added a commit
that referenced
this pull request
Mar 27, 2024
* Revert "Remove Models from Browse data (#40108)" This reverts commit 45a2e86. * Make rtl friendly * Add 'no description' for blank-description models * Fix vertical position of collection header toggle * Move FixedSizeIcon into metabase/ui and increase height of empty state * Move FixedSizeIcon back into BrowseModels.styled.tsx * Localize 'No description' * Add comment * Fix type issue
qnkhuat
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Revert "Remove Models from Browse data (#40108)" This reverts commit 45a2e86. * Make rtl friendly * Add 'no description' for blank-description models * Fix vertical position of collection header toggle * Move FixedSizeIcon into metabase/ui and increase height of empty state * Move FixedSizeIcon back into BrowseModels.styled.tsx * Localize 'No description' * Add comment * Fix type issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40037