-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Replacement Frontend #40480
CSV Replacement Frontend #40480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not versed in our FE ways, but implementation looks slick to me 😎
frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadStatusLarge.tsx
Show resolved
Hide resolved
c638043
to
3bc0a94
Compare
832186b
to
0078f68
Compare
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2f7952b...32cf2e3.
|
|
...base/query_builder/components/view/ViewHeader/components/QuestionActions/QuestionActions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
Closes #40469
Description
Adds a "replace" option for uploading CSVs
From a collection
![uploadModal](https://private-user-images.githubusercontent.com/30528226/315762588-76de497d-8229-4a9b-a908-5de97f3763d8.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1MzI3MTQsIm5iZiI6MTcyNTUzMjQxNCwicGF0aCI6Ii8zMDUyODIyNi8zMTU3NjI1ODgtNzZkZTQ5N2QtODIyOS00YTliLWE5MDgtNWRlOTdmMzc2M2Q4LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDEwMzMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZjYmU3ODFjNTNkMjdjOWU4ZGU5M2IzMmZhM2E4NTRhMTJmOWUwNGIzOWY2ZGQ5YzIzZWIyNzk4NGJlYmNjMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TZYri1EtiLirYmAXEujQY1oBbQcz6Xz9W45NKjliN4o)
From within an uploaded model
![withinModel](https://private-user-images.githubusercontent.com/30528226/315762532-5bd4d427-b814-4a6a-a98d-aabf3e714bd4.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1MzI3MTQsIm5iZiI6MTcyNTUzMjQxNCwicGF0aCI6Ii8zMDUyODIyNi8zMTU3NjI1MzItNWJkNGQ0MjctYjgxNC00YTZhLWE5OGQtYWFiZjNlNzE0YmQ0LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDEwMzMzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzYWU1Yjk4YmQ2NjA5ZjMzMDA4ZTc5NmRlODc3NWFmNjMzMWMyYWQ1ZGMxNzRhNTcyYTNhNDliYjgyODdmOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KECO0frO1DExGFBs1B3FaDm62-zhdb45CSpBY9-474Y)
How to verify
Checklist