Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV Replacement Frontend #40480

Merged
merged 5 commits into from
Mar 26, 2024
Merged

CSV Replacement Frontend #40480

merged 5 commits into from
Mar 26, 2024

Conversation

iethree
Copy link
Contributor

@iethree iethree commented Mar 21, 2024 •
edited
Loading

Closes #40469

Description

Adds a "replace" option for uploading CSVs

  1. From a collection
    uploadModal

  2. From within an uploaded model
    withinModel

How to verify

  1. Go to a collection with uploaded models, see that you can now replace their data
  2. go to an uploaded model, see that you can now replace its data
  3. all that model's data should be replaced!

Checklist

  • Tests have been added/updated to cover changes in this PR

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Mar 21, 2024
crisptrutski
crisptrutski reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@crisptrutski crisptrutski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not versed in our FE ways, but implementation looks slick to me 😎

frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadStatusLarge.tsx Show resolved Hide resolved
Base automatically changed from 2023-03-20-replace-csv to master March 22, 2024 11:40
@iethree iethree marked this pull request as ready for review March 22, 2024 19:34
@iethree iethree requested a review from a team March 22, 2024 19:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024 •
edited
Loading

Codenotify: Notifying subscribers in CODENOTIFY files for diff 2f7952b...32cf2e3.

Notify File(s)
@ranquild frontend/src/metabase/status/components/FileUploadStatus/FileUploadStatus.unit.spec.tsx
frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadStatusLarge.tsx

@replay-io replay.io
Copy link

replay-io bot commented Mar 22, 2024 •
edited
Loading

Status Complete ↗︎
Commit 32cf2e3
Results
⚠️ 6 Flaky
✅ 2377 Passed

@iethree iethree added the no-backport Do not backport this PR to any branch label Mar 22, 2024
sloansparger
sloansparger approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@sloansparger sloansparger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

frontend/src/metabase/status/components/FileUploadStatusLarge/FileUploadStatusLarge.tsx Outdated Show resolved Hide resolved
@iethree iethree enabled auto-merge (squash) March 26, 2024 16:29
@iethree iethree merged commit 4986483 into master Mar 26, 2024
108 checks passed
@iethree iethree deleted the csv/replace-frontend branch March 26, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisptrutski crisptrutski crisptrutski left review comments

@sloansparger sloansparger sloansparger approved these changes

Assignees

@iethree iethree

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV Replacement Frontend
3 participants
@iethree @crisptrutski @sloansparger