Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress bar display error in query builder #41330

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fix progress bar display error in query builder #41330

merged 2 commits into from
Apr 15, 2024

Conversation

JesseSDevaney
Copy link
Contributor

@JesseSDevaney JesseSDevaney added Visualization/Scalars Numbers, progress bars, gauges .Team/DashViz Dashboard and Viz team labels Apr 11, 2024
@JesseSDevaney JesseSDevaney requested a review from a team April 11, 2024 20:46
@JesseSDevaney JesseSDevaney self-assigned this Apr 11, 2024
@metabase-bot metabase-bot bot added the visual Run Percy visual testing label Apr 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited

Codenotify: Notifying subscribers in CODENOTIFY files for diff bb97466...9f2127d.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/visualizations/Progress/Progress.jsx

@replay-io replay.io
Copy link

replay-io bot commented Apr 11, 2024 •
edited

Status Complete ↗︎
Commit 9f2127d
Results
⚠️ 10 Flaky
✅ 2399 Passed

alxnddr
alxnddr reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@alxnddr alxnddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already got accidentally broken and we missed it, can you please add specs to ensure it won't get broken?

@JesseSDevaney JesseSDevaney added the backport Automatically create PR on current release branch on merge label Apr 15, 2024
alxnddr
alxnddr approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@alxnddr alxnddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding the spec!

@JesseSDevaney JesseSDevaney merged commit 7eb6bf6 into master Apr 15, 2024
109 of 110 checks passed
@JesseSDevaney JesseSDevaney deleted the 41243/fix-progress-visualizations-erroring-in-query-builder branch April 15, 2024 21:14
@github-actions GitHub Actions
Copy link

@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request Apr 15, 2024
@JesseSDevaney
Fix progress bar display error in query builder (#41330)
d669873 
* fix progress bar in query builder

* add spec to verify regression fix
@metabase-bot metabase-bot bot mentioned this pull request Apr 15, 2024
Merged
metabase-bot bot added a commit that referenced this pull request Apr 15, 2024
@metabase-bot @JesseSDevaney
Fix progress bar display error in query builder (#41330) (#41451)
e66aa28 
* fix progress bar in query builder

* add spec to verify regression fix

Co-authored-by: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxnddr alxnddr alxnddr approved these changes

Assignees

@JesseSDevaney JesseSDevaney

Labels
backport Automatically create PR on current release branch on merge .Team/DashViz Dashboard and Viz team visual Run Percy visual testing Visualization/Scalars Numbers, progress bars, gauges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress visualizations don't show, except on dashboards Progress visualisation not working, gives an error
2 participants
@JesseSDevaney @alxnddr